mirror of
https://github.com/psy0rz/zfs_autobackup.git
synced 2025-05-30 01:19:16 +03:00
Merge pull request #4 from mariusvw/hotfix/space_escape
Hotfix/space escape
This commit is contained in:
commit
009c3844bd
@ -140,10 +140,10 @@ test_snapshots={}
|
|||||||
|
|
||||||
"""create snapshot on multiple filesystems at once (atomicly)"""
|
"""create snapshot on multiple filesystems at once (atomicly)"""
|
||||||
def zfs_create_snapshot(ssh_to, filesystems, snapshot):
|
def zfs_create_snapshot(ssh_to, filesystems, snapshot):
|
||||||
cmd=[ "zfs", "snapshot" ]
|
|
||||||
|
|
||||||
|
snapshots=[]
|
||||||
for filesystem in filesystems:
|
for filesystem in filesystems:
|
||||||
cmd.append(filesystem+"@"+snapshot)
|
snapshots.append(filesystem+"@"+snapshot)
|
||||||
|
|
||||||
#in testmode we dont actually make changes, so keep them in a list to simulate
|
#in testmode we dont actually make changes, so keep them in a list to simulate
|
||||||
if args.test:
|
if args.test:
|
||||||
@ -153,8 +153,9 @@ def zfs_create_snapshot(ssh_to, filesystems, snapshot):
|
|||||||
test_snapshots[ssh_to][filesystem]=[]
|
test_snapshots[ssh_to][filesystem]=[]
|
||||||
test_snapshots[ssh_to][filesystem].append(snapshot)
|
test_snapshots[ssh_to][filesystem].append(snapshot)
|
||||||
|
|
||||||
run(ssh_to=ssh_to, tab_split=False, cmd=cmd, test=args.test)
|
run(ssh_to=ssh_to, test=args.test, input="\0".join(snapshots), cmd=
|
||||||
|
[ "xargs", "-0", "-n", "1", "zfs", "snapshot" ]
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
"""get names of all snapshots for specified filesystems belonging to backup_name
|
"""get names of all snapshots for specified filesystems belonging to backup_name
|
||||||
@ -162,12 +163,10 @@ def zfs_create_snapshot(ssh_to, filesystems, snapshot):
|
|||||||
return[filesystem_name]=[ "snashot1", "snapshot2", ... ]
|
return[filesystem_name]=[ "snashot1", "snapshot2", ... ]
|
||||||
"""
|
"""
|
||||||
def zfs_get_snapshots(ssh_to, filesystems, backup_name):
|
def zfs_get_snapshots(ssh_to, filesystems, backup_name):
|
||||||
cmd=[
|
|
||||||
"zfs", "list", "-d", "1", "-r", "-t" ,"snapshot", "-H", "-o", "name"
|
|
||||||
]
|
|
||||||
cmd.extend(filesystems)
|
|
||||||
|
|
||||||
snapshots=run(ssh_to=ssh_to, tab_split=False, cmd=cmd, valid_exitcodes=[ 0,1 ])
|
snapshots=run(ssh_to=ssh_to, input="\0".join(filesystems), valid_exitcodes=[ 0,1 ], cmd=
|
||||||
|
[ "xargs", "-0", "-n", "1", "zfs", "list", "-d", "1", "-r", "-t" ,"snapshot", "-H", "-o", "name" ]
|
||||||
|
)
|
||||||
|
|
||||||
ret={}
|
ret={}
|
||||||
for snapshot in snapshots:
|
for snapshot in snapshots:
|
||||||
@ -228,7 +227,10 @@ def zfs_transfer(ssh_source, source_filesystem, first_snapshot, second_snapshot,
|
|||||||
else:
|
else:
|
||||||
verbose("Tranferring "+source_filesystem+" incremental backup between snapshots "+first_snapshot+"..."+second_snapshot)
|
verbose("Tranferring "+source_filesystem+" incremental backup between snapshots "+first_snapshot+"..."+second_snapshot)
|
||||||
source_cmd.extend([ "-i", first_snapshot ])
|
source_cmd.extend([ "-i", first_snapshot ])
|
||||||
|
# FIXME needs attention
|
||||||
|
if ssh_source != "local":
|
||||||
|
source_cmd.append(source_filesystem.replace(' ', '\ ') + "@" + second_snapshot)
|
||||||
|
else:
|
||||||
source_cmd.append(source_filesystem + "@" + second_snapshot)
|
source_cmd.append(source_filesystem + "@" + second_snapshot)
|
||||||
|
|
||||||
# if ssh_source != "local":
|
# if ssh_source != "local":
|
||||||
@ -251,14 +253,17 @@ def zfs_transfer(ssh_source, source_filesystem, first_snapshot, second_snapshot,
|
|||||||
#also verbose in --verbose mode so we can see the transfer speed when its completed
|
#also verbose in --verbose mode so we can see the transfer speed when its completed
|
||||||
if args.verbose or args.debug:
|
if args.verbose or args.debug:
|
||||||
target_cmd.append("-v")
|
target_cmd.append("-v")
|
||||||
|
# FIXME needs attention
|
||||||
|
if ssh_target != "local":
|
||||||
|
target_cmd.append(target_filesystem.replace(' ', '\ '))
|
||||||
|
else:
|
||||||
target_cmd.append(target_filesystem)
|
target_cmd.append(target_filesystem)
|
||||||
|
|
||||||
|
|
||||||
#### make sure parent on target exists
|
#### make sure parent on target exists
|
||||||
parent_filesystem= "/".join(target_filesystem.split("/")[:-1])
|
parent_filesystem= "/".join(target_filesystem.split("/")[:-1])
|
||||||
run(ssh_to=ssh_target, cmd=[ "zfs", "create" ,"-p", parent_filesystem ], test=args.test)
|
run(ssh_to=ssh_target, test=args.test, input=parent_filesystem + "\0", cmd=
|
||||||
|
[ "xargs", "-0", "-n", "1", "zfs", "create" ,"-p" ]
|
||||||
|
)
|
||||||
|
|
||||||
### execute pipe
|
### execute pipe
|
||||||
debug_txt="# "+source_cmd[0]+" '"+("' '".join(source_cmd[1:]))+"'" + " | " + target_cmd[0]+" '"+("' '".join(target_cmd[1:]))+"'"
|
debug_txt="# "+source_cmd[0]+" '"+("' '".join(source_cmd[1:]))+"'" + " | " + target_cmd[0]+" '"+("' '".join(target_cmd[1:]))+"'"
|
||||||
@ -282,7 +287,9 @@ def zfs_transfer(ssh_source, source_filesystem, first_snapshot, second_snapshot,
|
|||||||
raise(subprocess.CalledProcessError(target_proc.returncode, target_cmd))
|
raise(subprocess.CalledProcessError(target_proc.returncode, target_cmd))
|
||||||
|
|
||||||
debug("Verifying if snapshot exists on target")
|
debug("Verifying if snapshot exists on target")
|
||||||
run(ssh_to=ssh_target, cmd=["zfs", "list", target_filesystem+"@"+second_snapshot ])
|
run(ssh_to=ssh_target, input=target_filesystem+"@"+second_snapshot + "\0", cmd=
|
||||||
|
[ "xargs", "-0", "-n", "1", "zfs", "list" ]
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
@ -475,7 +482,10 @@ for source_filesystem in source_filesystems:
|
|||||||
if send_snapshots and args.rollback and latest_target_snapshot:
|
if send_snapshots and args.rollback and latest_target_snapshot:
|
||||||
#roll back any changes on target
|
#roll back any changes on target
|
||||||
debug("Rolling back target to latest snapshot.")
|
debug("Rolling back target to latest snapshot.")
|
||||||
run(ssh_to=args.ssh_target, test=args.test, cmd=["zfs", "rollback", target_filesystem+"@"+latest_target_snapshot ])
|
|
||||||
|
run(ssh_to=args.ssh_target, test=args.test, input=target_filesystem+"@"+latest_target_snapshot + "\0", cmd=
|
||||||
|
[ "xargs", "-0", "-n", "1", "zfs", "rollback" ]
|
||||||
|
)
|
||||||
|
|
||||||
for send_snapshot in send_snapshots:
|
for send_snapshot in send_snapshots:
|
||||||
|
|
||||||
@ -491,11 +501,19 @@ for source_filesystem in source_filesystems:
|
|||||||
else:
|
else:
|
||||||
if args.clear_refreservation:
|
if args.clear_refreservation:
|
||||||
debug("Clearing refreservation to save space.")
|
debug("Clearing refreservation to save space.")
|
||||||
run(ssh_to=args.ssh_target, test=args.test, cmd=["zfs", "set", "refreservation=none", target_filesystem ])
|
|
||||||
|
run(ssh_to=args.ssh_target, test=args.test, input=target_filesystem + "\0", cmd=
|
||||||
|
[ "xargs", "-0", "-n", "1", "zfs", "set", "refreservation=none" ]
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
if args.clear_mountpoint:
|
if args.clear_mountpoint:
|
||||||
debug("Setting canmount=noauto to prevent auto-mounting in the wrong place. (ignoring errors)")
|
debug("Setting canmount=noauto to prevent auto-mounting in the wrong place. (ignoring errors)")
|
||||||
run(ssh_to=args.ssh_target, test=args.test, cmd=["zfs", "set", "canmount=noauto", target_filesystem ], valid_exitcodes= [0, 1] )
|
|
||||||
|
run(ssh_to=args.ssh_target, test=args.test, input=target_filesystem + "\0", valid_exitcodes= [0, 1], cmd=
|
||||||
|
[ "xargs", "-0", "-n", "1", "zfs", "set", "canmount=noauto" ]
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
latest_target_snapshot=send_snapshot
|
latest_target_snapshot=send_snapshot
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user