third-party-mirrors/zfs_autobackup
1
0
Fork 1
mirror of https://github.com/psy0rz/zfs_autobackup.git synced 2025-06-09 01:52:07 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

zfs-verify stuff

Browse Source
This commit is contained in:
Edwin Eefting 2022-01-18 23:46:08 +01:00
parent 86d504722c
commit 787e3dba9c
3 changed files with 82 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/basetest.py
View File

@ -11,6 +11,7 @@ import subprocess
import time import time
from pprint import * from pprint import *
from zfs_autobackup.ZfsAutobackup import * from zfs_autobackup.ZfsAutobackup import *
from zfs_autobackup.ZfsAutoverify import *
from mock import * from mock import *
import contextlib import contextlib
import sys import sys

38
tests/test_verify.py
View File

@ -1,17 +1,16 @@
from zfs_autobackup.CmdPipe import CmdPipe
from basetest import * from basetest import *
import time
# test zfs-verify: # test zfs-verify:
# - when there is no common snapshot at all # - when there is no common snapshot at all
# - when encryption key not loaded # - when encryption key not loaded
# - on datasets: # - test mode
# - on snapshots of datasets:
# - that are correct # - that are correct
# - that are different # - that are different
# - that are not mounted # - because of rsync: test local/local, local remote etc
# - that are mounted # - on snapshots of zvols
# - that are mounted on the "wrong" place
# - on zvols
# - that are correct # - that are correct
# - that are different # - that are different
# #
@ -36,28 +35,7 @@ class TestZfsEncryption(unittest2.TestCase):
def test_verify(self): def test_verify(self):
return self.assertFalse(ZfsAutoverify("test test_target1 --verbose --test".split(" ")).run())
r = shelltest("zfs get -r -t filesystem encryptionroot test_target1") self.assertFalse(ZfsAutoverify("test test_target1 --verbose --debug".split(" ")).run())
self.assertMultiLineEqual(r,"""
NAME PROPERTY VALUE SOURCE
test_target1 encryptionroot - -
test_target1/encryptedtarget encryptionroot test_target1/encryptedtarget -
test_target1/encryptedtarget/test_source1 encryptionroot test_target1/encryptedtarget -
test_target1/encryptedtarget/test_source1/fs1 encryptionroot - -
test_target1/encryptedtarget/test_source1/fs1/encryptedsource encryptionroot test_target1/encryptedtarget/test_source1/fs1/encryptedsource -
test_target1/encryptedtarget/test_source1/fs1/encryptedsourcekeyless encryptionroot test_target1/encryptedtarget/test_source1/fs1/encryptedsourcekeyless -
test_target1/encryptedtarget/test_source1/fs1/sub encryptionroot - -
test_target1/encryptedtarget/test_source2 encryptionroot test_target1/encryptedtarget -
test_target1/encryptedtarget/test_source2/fs2 encryptionroot test_target1/encryptedtarget -
test_target1/encryptedtarget/test_source2/fs2/sub encryptionroot - -
test_target1/test_source1 encryptionroot - -
test_target1/test_source1/fs1 encryptionroot - -
test_target1/test_source1/fs1/encryptedsource encryptionroot test_target1/test_source1/fs1/encryptedsource -
test_target1/test_source1/fs1/encryptedsourcekeyless encryptionroot test_target1/test_source1/fs1/encryptedsourcekeyless -
test_target1/test_source1/fs1/sub encryptionroot - -
test_target1/test_source2 encryptionroot - -
test_target1/test_source2/fs2 encryptionroot - -
test_target1/test_source2/fs2/sub encryptionroot - -
""")

75
zfs_autobackup/ZfsAutoverify.py
View File

@ -1,7 +1,11 @@
import os
from .ZfsAuto import ZfsAuto from .ZfsAuto import ZfsAuto
from .ZfsDataset import ZfsDataset from .ZfsDataset import ZfsDataset
from .ZfsNode import ZfsNode from .ZfsNode import ZfsNode
import sys import sys
import platform
class ZfsAutoverify(ZfsAuto): class ZfsAutoverify(ZfsAuto):
"""The zfs-autoverify class, default agruments and stuff come from ZfsAuto""" """The zfs-autoverify class, default agruments and stuff come from ZfsAuto"""
@ -30,7 +34,16 @@ class ZfsAutoverify(ZfsAuto):
return (parser) return (parser)
def verify_datasets(self, source_node, source_datasets, target_node):
def verify_filesystem(self, source_dataset, source_mnt, target_dataset, target_mnt):
pass
def verify_volume(self, source_dataset, target_dataset):
pass
def verify_datasets(self, source_node, source_mnt, source_datasets, target_node, target_mnt):
fail_count=0 fail_count=0
count = 0 count = 0
@ -47,7 +60,12 @@ class ZfsAutoverify(ZfsAuto):
target_dataset = ZfsDataset(target_node, target_name) target_dataset = ZfsDataset(target_node, target_name)
if source_dataset.properties['type']=="filesystem": if source_dataset.properties['type']=="filesystem":
print("JOOO") self.verify_filesystem(source_dataset, source_mnt, target_dataset, target_mnt)
elif source_dataset.properties['type']=="volume":
self.verify_volume(source_dataset, target_dataset)
else:
raise(Exception("{} has unknown type {}".format(source_dataset, source_dataset.properties['type'])))
except Exception as e: except Exception as e:
fail_count = fail_count + 1 fail_count = fail_count + 1
@ -55,10 +73,31 @@ class ZfsAutoverify(ZfsAuto):
if self.args.debug: if self.args.debug:
raise raise
def create_mountpoints(self, source_node, target_node):
# prepare mount points
source_mnt = "/tmp/zfs-autoverify_source_{}_{}".format(platform.node(), os.getpid())
source_node.run(["mkdir", source_mnt])
target_mnt = "/tmp/zfs-autoverify_target_{}_{}".format(platform.node(), os.getpid())
target_node.run(["mkdir", target_mnt])
return source_mnt, target_mnt
def cleanup_mountpoint(self, node, mnt):
node.run([ "umount", mnt ], hide_errors=True, valid_exitcodes=[] )
node.run([ "rmdir", mnt ], hide_errors=True, valid_exitcodes=[] )
def run(self): def run(self):
source_node=None
source_mnt=None
target_node=None
target_mnt=None
try: try:
################ create source zfsNode ################ create source zfsNode
@ -90,11 +129,32 @@ class ZfsAutoverify(ZfsAuto):
description="[Target]") description="[Target]")
target_node.verbose("Verify datasets under: {}".format(self.args.target_path)) target_node.verbose("Verify datasets under: {}".format(self.args.target_path))
source_mnt, target_mnt=self.create_mountpoints(source_node, target_node)
fail_count = self.verify_datasets( fail_count = self.verify_datasets(
source_node=source_node, source_node=source_node,
source_mnt=source_mnt,
source_datasets=source_datasets, source_datasets=source_datasets,
target_mnt=target_mnt,
target_node=target_node) target_node=target_node)
if not fail_count:
if self.args.test:
self.set_title("All tests successful.")
else:
self.set_title("All datasets verified ok")
else:
if fail_count != 255:
self.error("{} dataset(s) failed!".format(fail_count))
if self.args.test:
self.verbose("")
self.warning("TEST MODE - DID NOT VERIFY ANYTHING!")
return fail_count
except Exception as e: except Exception as e:
self.error("Exception: " + str(e)) self.error("Exception: " + str(e))
if self.args.debug: if self.args.debug:
@ -103,6 +163,17 @@ class ZfsAutoverify(ZfsAuto):
except KeyboardInterrupt: except KeyboardInterrupt:
self.error("Aborted") self.error("Aborted")
return 255 return 255
finally:
# cleanup
if source_mnt is not None:
self.cleanup_mountpoint(source_node, source_mnt)
if target_mnt is not None:
self.cleanup_mountpoint(target_node, target_mnt)
def cli(): def cli():
import sys import sys