third-party-mirrors/zfs_autobackup
1
0
Fork 1
mirror of https://github.com/psy0rz/zfs_autobackup.git synced 2025-06-03 01:30:57 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

add --no-progress to workaround zfs recv bug

Browse Source
This commit is contained in:
Edwin Eefting 2021-02-06 22:22:38 +01:00
parent 48f1f6ec5d
commit b6627eb389
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
README.md
View File

@ -22,6 +22,7 @@ zfs-autobackup tries to be the easiest to use backup tool for zfs.
## Features ## Features
* Works across operating systems: Tested with **Linux**, **FreeBSD/FreeNAS** and **SmartOS**. * Works across operating systems: Tested with **Linux**, **FreeBSD/FreeNAS** and **SmartOS**.
* Low learning curve: no complex daemons or services, no additional software or networking needed. (Only read this page)
* Plays nicely with existing replication systems. (Like Proxmox HA) * Plays nicely with existing replication systems. (Like Proxmox HA)
* Automatically selects filesystems to backup by looking at a simple ZFS property. (recursive) * Automatically selects filesystems to backup by looking at a simple ZFS property. (recursive)
* Creates consistent snapshots. (takes all snapshots at once, atomicly.) * Creates consistent snapshots. (takes all snapshots at once, atomicly.)
@ -391,7 +392,7 @@ To be bold I created 2500 datasets, but that also was no problem. So it seems it
If you need more performance let me know. If you need more performance let me know.
NOTE: The is actually a performance regression in ZFS version 2: https://github.com/openzfs/zfs/issues/11560 (I commented out line 1652: '# args.progress = True' as temporary workaround) NOTE: There is actually a performance regression in ZFS version 2: https://github.com/openzfs/zfs/issues/11560 Use --no-progress as workaround.
#### Less work #### Less work

6
bin/zfs-autobackup
View File

@ -1641,14 +1641,16 @@ class ZfsAutobackup:
parser.add_argument('--debug-output', action='store_true', parser.add_argument('--debug-output', action='store_true',
help='Show zfs commands and their output/exit codes. (noisy)') help='Show zfs commands and their output/exit codes. (noisy)')
parser.add_argument('--progress', action='store_true', parser.add_argument('--progress', action='store_true',
help='show zfs progress output (to stderr). Enabled by default on ttys.') help='show zfs progress output. Enabled automaticly on ttys. (use --no-progress to disable)')
parser.add_argument('--no-progress', action='store_true', help=argparse.SUPPRESS) #needed to workaround a zfs recv -v bug
# note args is the only global variable we use, since its a global readonly setting anyway # note args is the only global variable we use, since its a global readonly setting anyway
args = parser.parse_args(argv) args = parser.parse_args(argv)
self.args = args self.args = args
if sys.stderr.isatty(): #auto enable progress?
if sys.stderr.isatty() and not args.no_progress:
args.progress = True args.progress = True
if args.debug_output: if args.debug_output: