[#559] Prevent EDMC Crash -> No Update

This commit is contained in:
David Sangrey committed 2026-01-03 21:21:12 -05:00
1 parent f69a45584f
commit f345dc6715
3 files changed
+9 -1

No files matched your search

+1
View File
@@ -1624,6 +1624,7 @@ class AppWindow:
# Disable WinSparkle automatic update checks, IFF configured to do so when in-game
if config.get_int('disable_autoappupdatecheckingame'):
if self.updater is not None:
config.set("core_updater_disable_in_game", self.updater.get_update_check())
self.updater.set_automatic_updates_check(False)
logger.info('Monitor: Disable WinSparkle automatic update checks')
+1 -1
View File
@@ -54,7 +54,7 @@ appcmdname = "EDMC"
# <https://semver.org/#semantic-versioning-specification-semver>
# Major.Minor.Patch(-prerelease)(+buildmetadata)
# NB: Do *not* import this, use the functions appversion() and appversion_nobuild()
_static_appversion = "6.0.2"
_static_appversion = "6.1.0-alpha0"
_cached_version: semantic_version.Version | None = None
copyright = "© 2015-2019 Jonathan Harris, 2020-2025 EDCD"
+7
View File
@@ -224,6 +224,7 @@ class Updater:
if not self.use_internal() and sys.platform == 'win32':
self._init_winsparkle()
self.set_automatic_updates_check(config.get_bool("core_updater_disable_in_game", default=False))
def start_check_thread(self) -> None:
"""Start the background update worker thread safely."""
@@ -395,6 +396,12 @@ class Updater:
status['text'] = tr.tl("{NEWVER} is available").format(NEWVER=newver_title)
self.root.update_idletasks()
def get_update_check(self):
"""Check the current value of the WinSparkle Registry Key."""
if sys.platform == 'win32' and self.updater:
return self.updater.win_sparkle_set_automatic_check_for_updates()
return None
def close(self) -> None:
"""
Handle the EDMarketConnector.AppWindow.onexit() request.