A_D
40aa4f9e63
Added whitespace on scope changes
2020-07-26 23:08:47 +01:00
A_D
a6d6599c3b
Moved logfile regexp to class level constant
...
Regular expressions are expensive to recompile constantly, and while the
python regexp library currently caches reuse, it only does so to a point
and that is not a required behaviour.
Compiling regexps once is simply best practice. On top of this, the
regexp was duplicated in various places.
2020-07-26 23:08:47 +01:00
A_D
b010b8015d
Aligned values of large dicts
...
helps your eyes track the changes
2020-07-26 23:08:47 +01:00
A_D
ed45d59af1
Replaced modulo formatters with .format formatters
2020-07-26 23:08:47 +01:00
A_D
05e6d49880
replaced list comp with generator where possible
2020-07-26 23:08:47 +01:00
A_D
33f25da270
Fixed ambiguous names and logic
2020-07-26 23:08:47 +01:00
A_D
1963140572
removed star import
2020-07-26 23:08:47 +01:00
A_D
f95bfd4280
removed bare except clauses
2020-07-26 23:08:47 +01:00
A_D
bf74e3647f
Fixed various whitespace issues
2020-07-26 23:08:47 +01:00
A_D
aeb328b31f
Removed oneliners
2020-07-26 23:08:47 +01:00
A_D
d877de2758
Ensured all lines are under 120 characters wide
2020-07-26 23:08:47 +01:00
A_D
86dea84e94
Removed tabs preceeding inline comments
2020-07-26 23:08:47 +01:00
A_D
a40cebc749
Added whitespace around scope changes
...
Helps with reading code later
2020-07-26 23:08:47 +01:00
A_D
ce7c6d4333
removed unused variable
2020-07-26 23:08:47 +01:00
A_D
a9f4f5d507
made all regexps raw strings
...
ensures no weirdness from escapes
2020-07-26 23:08:47 +01:00
A_D
ba67db3f13
removed unused imports
2020-07-26 23:08:47 +01:00
Athanasius
6ba1f77352
Remove greet-everyone workflow, we've gotten things working now
2020-07-26 23:04:37 +01:00
Athanasius
df3f70b7ed
Rename to push-checks.yml, don't do PRs
...
Also commented better at the top
2020-07-26 23:03:23 +01:00
Athanasius
6513db3aca
Don't force --show-source in .flake8 !
...
This was the cause of our flake8-your-pr issue! It meant that as well
as `--format json` giving JSON output it also got polluted with the raw
string of the source line as well.
2020-07-26 23:03:23 +01:00
Athanasius
d65176aed8
Add flake8-json to requirements-dev.txt
2020-07-26 23:03:23 +01:00
Athanasius
8dbb275dca
Specify GITHUB_TOKEN for flake8-your-pr via env
2020-07-26 23:03:23 +01:00
Athanasius
63d44bf8d7
Attempt to run "tayfun/flake8-your-pr@master" in PRs.
2020-07-26 23:03:22 +01:00
Athanasius
333ba24db4
Rename to 'what it runs on' prefix
2020-07-26 23:03:06 +01:00
Athanasius
e461fa62f6
The configuration must be inside a 'with:'
2020-07-26 23:01:10 +01:00
Athanasius
4a3c74ce5b
Use fetch-depth 0 for 'all' on checkout@v2
2020-07-26 23:01:10 +01:00
Athanasius
f41eb4fb92
Try A_D's "diff only" flake8 checking
2020-07-26 23:01:10 +01:00
Athanasius
838e55710d
Uncomment flake8 part of build in workflow
2020-07-26 23:01:10 +01:00
Athanasius
fd78df246a
Comments out py2exe in requirements-dev.txt as it trips up GitHub Actions
...
docs/Releasing.md has fuller instructions on getting that specific
pyexe version installed anyway.
2020-07-26 23:01:10 +01:00
Athanasius
a76aae9737
Remove pytest and comment out flake8 for now.
...
Narrowing down what's working and what isn't in this.
2020-07-26 23:01:10 +01:00
Athanasius
607770f7d4
Add greet-example to github workflows
2020-07-26 20:23:02 +01:00
Athanasius
04fa3fae2c
Update python-app.yml
...
Change to ubuntu-18.04
2020-07-26 18:57:52 +01:00
Athanasius
f7968bd0c8
Update python-app.yml
...
Change name to be more obvious when viewing in Actions.
2020-07-26 18:49:10 +01:00
Athanasius
525baf8b03
Create python-app.yml
...
Add a GitHub Action to check requirements-dev.txt, flake8, and pytest.
2020-07-26 18:27:24 +01:00
Athanasius
022cc2b4ba
Merge branch 'release-4.0.3' into main
2020-07-24 14:32:46 +01:00
Athanasius
4705bb2bd3
Merge branch 'stable' into main
2020-07-24 14:32:06 +01:00
Athanasius
04122b2de6
Releasing.md: Emphasises that sparkle:version is SemVer string.
2020-07-24 14:28:34 +01:00
Athanasius
982e77c38a
Use SemVer for sparkle:version
...
Else it thinks 4.0.3.0 > 4.0.3 and keeps offering the upgrade.
2020-07-24 14:22:11 +01:00
Athanasius
6d40d9dcdf
Use SemVer for sparkle:version
...
Else it thinks 4.0.3.0 > 4.0.3 and keeps offering the upgrade.
2020-07-24 14:20:29 +01:00
Athanasius
f027d1fa92
Releasing.md: Update 'Known Issues' after a stable release.
2020-07-24 13:45:18 +01:00
Athanasius
0e1c7dbf95
Translations: Add 'Use alternate URL method' to phrases
2020-07-24 13:45:18 +01:00
A_D
d41dc38162
Create Enhancement issue template
...
closes #599
2020-07-24 13:45:17 +01:00
A_D
783b3c5ce9
clarified docs
2020-07-24 13:45:17 +01:00
A_D
0b2b76a9f5
Replaced write out checks with guard clauses
...
Guard clauses reduce indentation and help when reading code as they
remove a variable and indentation level that the reader would otherwise
need to keep track of
2020-07-24 13:45:17 +01:00
A_D
05de5b557e
Removed repeated int(key)
...
With the previous formatting changes there is no reason to leave key as
possibly a string anywhere, as it was already being converted to an int
everywhere anyway
2020-07-24 13:45:17 +01:00
A_D
8856cec36f
Move file backup code to a method
...
It was repeated in various places and increased noise
2020-07-24 13:45:17 +01:00
A_D
c233fa5ff5
Refactor __main__ logic
...
Most of this is just de-pyramiding the code, removing else clauses that
are unneeded (or making the if such that the else is not needed).
Rationale is simple, every level of indentation adds more that the
reader needs to keep track of.
2020-07-24 13:45:17 +01:00
A_D
5583486589
replace list literals with tuples
...
Tuples ensure that this isnt changed at runtime
2020-07-24 13:45:17 +01:00
A_D
6b73161cae
Replace AssertionErrors with ValueError
...
AssertionError comes from `assert`s, using it for this doesn't make sense as we're complaining about values
2020-07-24 13:45:17 +01:00
A_D
a40b085303
replace modulo formatting with .format
2020-07-24 13:45:17 +01:00
A_D
ec6a09a06d
removed oneline statements
2020-07-24 13:45:17 +01:00
