Commit Graph
1511 Commits
Author SHA1 Message Date
A_D 4aa8e2ca0e Added variable for re-used accesses
The last starport ID and name was repeatedly accessed out of a dict,
making lines longer and harder to parse
2020-07-07 18:42:16 +02:00
A_D e739923083 Moved User Agent to constant
This is one of those things that really should be a constant anyway
2020-07-07 18:37:05 +02:00
A_D 5c4c9fd3a7 Added error messages to exceptions where possible
Adds messages to exceptions where they may be useful and I could figure
out what they should be
2020-07-07 18:30:29 +02:00
A_D 34b963620a Removed bare except clauses
Bare except clauses are a fantastic way to find your HTTP requests
eating your ^C. I replaced all bare excepts with Exception if I could
not find a list of exceptions that could be thrown.
2020-07-07 18:21:48 +02:00
A_D 9363b1457d Simplified if ladder
Removed a large if ladder with a simpler construct that does the same
thing
2020-07-07 16:59:03 +02:00
A_D 31e0758ee4 Replaced x in $list construct with x in $tuple
Tuples are smaller and immutable, therefore using a tuple is cleaner.
2020-07-07 15:52:45 +02:00
A_D 7260dff9a2 Replaced modulo formatting with .format calls
Modulo formatting is py2 (and C printf) style, its arcane and incredibly
hard to read for large formats.

I used keyed .formats where there were more than a few format specifiers
2020-07-07 15:52:44 +02:00
A_D 765dc0bcf3 Replaced oneline ifs with multiline ifs
Oneline ifs are in general a bad idea in whitespace significant
languages, this replaces them with their multi-line equivalents
2020-07-07 15:52:44 +02:00
A_D 56d4d13d4d Fixed line spacing and comment length
This adds newlines after blocks and in other logical places to assist
with reading the code. Additionally, comments that were too long to
remain inline within a 120 character limit have been moved above the
line they reference.
2020-07-07 15:52:43 +02:00
Athanasius 98227b7af0 Merge pull request #562 from A-UNDERSCORE-D/enhancement/cleanup
Cleanup commodity.py (PEP8, code simplification)
2020-07-07 14:26:41 +01:00
Athanasius 273e121736 PLUGINS.md: Installation instructions on wiki 2020-07-06 18:22:02 +01:00
Athanasius d50d141a8e README.md: Missing ) on disclaimer 2020-07-06 18:13:56 +01:00
Athanasius 2426d9381f README.md: Update forum URLs for disclaimer.
* The old-forum format URL didn't work, managed to find the post and
   get the current URL.
 * Added link to when Journal files were announced.
2020-07-06 18:09:34 +01:00
Athanasius 4d96a062da README.md: Fix 'documenation' typo 2020-07-06 17:36:12 +01:00
Athanasius 344351b1fa README.md: Minor formatting edits
* Move 'Running from source' to just after installation.
 * Consistently use '---' headings.
 * Shorten heading markdown to --- or ===
2020-07-06 17:32:11 +01:00
A_D 76e561d231 Cleanup commodity.py (PEP8, code simplification)
I removed most of the overly complex oneliners for equivalent multi-line
constructs. The code behaviour should remain the same.

Otherwise mostly reformatting happened here, spaces after commas, that
sort of thing.
2020-07-06 18:30:23 +02:00
Athanasius 38bddd9bd9 README.md: Config files and different drive -> wiki 2020-07-06 17:17:33 +01:00
Athanasius c02cd8d9cb README.md: 'Update Error' is in the wiki Troubleshooting 2020-07-06 17:16:34 +01:00
Athanasius 032614304a README.md: Plugins? Wiki! 2020-07-06 17:14:30 +01:00
Athanasius 295087946f README.md: Main blurb is in Wiki, direct there 2020-07-06 17:12:01 +01:00
Athanasius bff215d92e README.md: Uninstall also on Wiki now 2020-07-06 16:57:41 +01:00
Athanasius 19d043a66a README.md: Remove the "new maintainer" blurb
It's been a few weeks, anyone who was going to see it in the critical
time frame either has or hasn't now.

Leave the pointer to Discord at the top though.
2020-07-06 16:48:08 +01:00
Athanasius ea631949ca README.md: Running from source -> wiki, Packaging -> Releasing.md 2020-07-06 16:36:49 +01:00
Athanasius a955612e28 PRIVACY.md: This is all on the wiki 2020-07-06 16:31:04 +01:00
Athanasius 6c598ad77f README.md: Reference Wiki for "Installation" 2020-07-06 16:25:51 +01:00
Athanasius f3401dcdea README.md: Reference wiki for Acknowledgements 2020-07-06 16:20:32 +01:00
Athanasius f1cb5b98fa README.md: Reference Wiki for Troubleshooting
There's no point keeping this up to date in two places.

Part of reducing the 'wall of text' nature of this file.
2020-07-06 16:16:34 +01:00
Athanasius 65793bce24 Contributing.md: develop is default branch, XXX- issue number optional 2020-07-06 16:05:09 +01:00
Athanasius 733047c11b Releasing.md: Release tags are Release/A.B.C.D 2020-07-06 16:04:27 +01:00
Athanasius 2f9b564f90 Merge branch 'develop' into python3 2020-07-05 20:50:29 +01:00
Athanasius e020c24f12 Merge branch 'release-3.99.2.0' into develop Release/3.99.2.0 2020-07-05 20:12:04 +01:00
Athanasius 1a22b88d8a README.md: Thank Gurra for Swedish translation 2020-07-05 20:11:37 +01:00
Athanasius a21809d98f Merge branch 'develop' of https://github.com/EDCD/EDMarketConnector into develop 2020-07-05 20:10:51 +01:00
Athanasius a64671015b Merge branch 'beta' into develop 2020-07-05 20:10:36 +01:00
Athanasius 87c4139bbb Merge branch 'beta' into develop 2020-07-05 20:08:52 +01:00
Athanasius 252b1a648d Merge pull request #558 from EDCD/release-3.99.2.0
Release 3.99.2.0
2020-07-05 20:07:49 +01:00
Athanasius c4c2a84143 Merge branch 'beta' into release-3.99.2.0 2020-07-05 20:05:50 +01:00
Athanasius 719fa082a9 Changelog for 3.99.2.0 2020-07-05 20:04:41 +01:00
Athanasius 7e838953c9 Increase version to 3.99.2.0 2020-07-05 20:01:05 +01:00
Athanasius 1a8410e9a2 Update translations ready for 3.99.2.0 2020-07-05 19:58:36 +01:00
Athanasius 26da1be135 Merge branch 'issue/549-helper-scripts' into develop 2020-07-05 19:50:32 +01:00
Athanasius 085333c80b Update issue templates 2020-07-05 19:46:02 +01:00
Athanasius 1a18c2be9b Merge branch 'develop' into python3 2020-07-05 19:41:07 +01:00
Athanasius 80cf6975a8 Merge pull request #557 from EDCD/l10n/Add-Swedish
Add Swedish Translation
2020-07-05 19:34:56 +01:00
Athanasius 72bed8fc17 Add Swedish, sv-SE, to .wxs file for installation 2020-07-05 19:30:22 +01:00
Athanasius 58078546ac Add Swedish Translationo
TODO: Add to installer setup so it will be in the next release.
2020-07-05 16:21:45 +01:00
Athanasius e21fc8f4c5 Merge branch 'develop' of https://github.com/EDCD/EDMarketConnector into develop 2020-07-05 16:16:44 +01:00
Athanasius 2de8b9b94f docs/Translations: Finalize "don't translate" phrases immediately. 2020-07-05 16:16:18 +01:00
Athanasius d6d2ef3450 Merge pull request #554 from Athanasius/fix/Registry-Marginal-Winsparkle
Fix WinSparkle options to be under EDCD key
2020-07-04 11:52:42 +01:00
Athanasius dbc177a02c Fix WinSparkle options to be under EDCD key
* When I changed 'company_name' in setup.py to 'EDCD' this caused WinSparkle to
   store, and look for, its keys there.
 * There's code in config.py that attempts to set some WinSparkle options, only
   if they weren't already there.  This is hardcoded to use the old 'Marginal'
   Registry Key.

So, explicitly do this WinSparkle setup under 'EDCD', and *always* set the
update_interval value to match what we expect.  Leave the 'CheckForUpdates'
under the 'is it already here?' check so that we respect the user's choice.
2020-07-04 11:51:01 +01:00