This adds newlines after blocks and in other logical places to assist
with reading the code. Additionally, comments that were too long to
remain inline within a 120 character limit have been moved above the
line they reference.
I removed most of the overly complex oneliners for equivalent multi-line
constructs. The code behaviour should remain the same.
Otherwise mostly reformatting happened here, spaces after commas, that
sort of thing.
It's been a few weeks, anyone who was going to see it in the critical
time frame either has or hasn't now.
Leave the pointer to Discord at the top though.
* When I changed 'company_name' in setup.py to 'EDCD' this caused WinSparkle to
store, and look for, its keys there.
* There's code in config.py that attempts to set some WinSparkle options, only
if they weren't already there. This is hardcoded to use the old 'Marginal'
Registry Key.
So, explicitly do this WinSparkle setup under 'EDCD', and *always* set the
update_interval value to match what we expect. Leave the 'CheckForUpdates'
under the 'is it already here?' check so that we respect the user's choice.
The added exception at least means we don't then segmentation fault in
the next line, but it also means we then hit another exception later
in the main loop as we try to create the main Tk window.
Hopefully the exception messages will be clear enough to the user.
closes#500
A user accidentally copied a Journal file into the same directory, resulting in
a "Journal.<datetime>.<serial> - Copy.log" file. EDMC 3.99.0.0 then picked this
up and re-sent events to EDDN, EDSM, Inara.
So, let's be strict about the filenames we consider to be valid, live, Journal
files.
* Journal files have one basic form: Journal.YYMMDDHHMMSS.XX.log
* In addition the word 'Beta' can be inserted just after 'Journal'
So regex '^Journal(Beta)?\.[0-9]{12}\.[0-9]{2}\.log$' matches both and nothing
else.
Test: The "copy to same directory" that originally triggered this. EDMC no
longer 'sees' the copy.
Test: Copied a Journal file out, renamed it to later date/time, copied that
back in. EDMC saw it correctly as a new file.
NB: Didn't test the "no emitter" version at monitor.py:251, but no reason to
think it won't also work.
closes#546
A_D
Athanasius
Athanasius