Doing so causes the ShipType to not be used in the UI, so you get a
'link' with just a space for the text.
Any user who purposefully sets their ship's name to a single space
can live with seeing the model name instead. Yes, I checked, the game
allows it.
I got too enthusiastic in 3ff77c3c54dea4bf36d957cd2dbd5b1b02dcb094 when
I removed the "cut it down to A.BC" code. This restores the old output,
but using a less confusing if/else.
* Cleans up imports.
* Fixes some '<tab># ...' to use 2 spaces.
* Add type hints to system_url().
* Always store, even if not current provider: this.{system_address,
station_marketid,system_population}
* Note in monitor.py to update the docs if anything changed about the
'state' dictionary.
* Expand on arguments to all plugin call-ins.
* Particularly what the 'state' diction passed to journal_entry()
contains.
* The contents of the `data` dictionary passed to `cmdr_data()`.
This works by checking on _any_ event the status of the cargo vs the
current stored version. If the live cargo differs from the updated
cargo, _and_ we have not sent any update in the past 45 seconds (as this
would have contained the cargo anyway), we queue an actual send to the
API.
This unfortunately isn't checked only when docked, but on the plus side
miners will be happy to have their cargo updated relatively often.
Fixes#477. Possibly not quite what they wanted, but its about as close
as this will get
We need a better way to do provider defaults. Heck, settings defaults period.
Let's assume we'll put in place a "standard" config file once we move to one.
See issue #586 - a user had incorrect system_address set, but only sometimes.
This could possibly be due to CAPI errors/lag, so only use it as the source
when the values aren't yet set. Otherwise Journal should always have provided
the correct value in a timely manner.
The UI for setting the 'anonymous' option was removed in
f17f5d3f257e2359d4728ce8c296d70dc5e7609f ("PKCE OAuth2 access to cAPI").
Since then there's been no way for a user to set, or unset, this option
(and the associated custom uploaderID). However anyone with the registry keys
still set would have had them take effect.
This commit removes the last bits of code that were making use of it.
Note that the EDDN Relay anonymises all uploaderID values, so no listener
has been seeing the 'raw' values for a long time now.
close#575
