Commit Graph
1686 Commits
Author SHA1 Message Date
Athanasius 838e55710d Uncomment flake8 part of build in workflow 2020-07-26 23:01:10 +01:00
Athanasius fd78df246a Comments out py2exe in requirements-dev.txt as it trips up GitHub Actions
docs/Releasing.md has fuller instructions on getting that specific
pyexe version installed anyway.
2020-07-26 23:01:10 +01:00
Athanasius a76aae9737 Remove pytest and comment out flake8 for now.
Narrowing down what's working and what isn't in this.
2020-07-26 23:01:10 +01:00
Athanasius 607770f7d4 Add greet-example to github workflows 2020-07-26 20:23:02 +01:00
Athanasius 04fa3fae2c Update python-app.yml
Change to ubuntu-18.04
2020-07-26 18:57:52 +01:00
Athanasius f7968bd0c8 Update python-app.yml
Change name to be more obvious when viewing in Actions.
2020-07-26 18:49:10 +01:00
Athanasius 525baf8b03 Create python-app.yml
Add a GitHub Action to check requirements-dev.txt, flake8, and pytest.
2020-07-26 18:27:24 +01:00
Athanasius 022cc2b4ba Merge branch 'release-4.0.3' into main 2020-07-24 14:32:46 +01:00
Athanasius 4705bb2bd3 Merge branch 'stable' into main 2020-07-24 14:32:06 +01:00
Athanasius 04122b2de6 Releasing.md: Emphasises that sparkle:version is SemVer string. 2020-07-24 14:28:34 +01:00
Athanasius 982e77c38a Use SemVer for sparkle:version
Else it thinks 4.0.3.0 > 4.0.3 and keeps offering the upgrade.
2020-07-24 14:22:11 +01:00
Athanasius 6d40d9dcdf Use SemVer for sparkle:version
Else it thinks 4.0.3.0 > 4.0.3 and keeps offering the upgrade.
2020-07-24 14:20:29 +01:00
Athanasius f027d1fa92 Releasing.md: Update 'Known Issues' after a stable release. 2020-07-24 13:45:18 +01:00
Athanasius 0e1c7dbf95 Translations: Add 'Use alternate URL method' to phrases 2020-07-24 13:45:18 +01:00
A_D d41dc38162 Create Enhancement issue template
closes #599
2020-07-24 13:45:17 +01:00
A_D 783b3c5ce9 clarified docs 2020-07-24 13:45:17 +01:00
A_D 0b2b76a9f5 Replaced write out checks with guard clauses
Guard clauses reduce indentation and help when reading code as they
remove a variable and indentation level that the reader would otherwise
need to keep track of
2020-07-24 13:45:17 +01:00
A_D 05de5b557e Removed repeated int(key)
With the previous formatting changes there is no reason to leave key as
possibly a string anywhere, as it was already being converted to an int
everywhere anyway
2020-07-24 13:45:17 +01:00
A_D 8856cec36f Move file backup code to a method
It was repeated in various places and increased noise
2020-07-24 13:45:17 +01:00
A_D c233fa5ff5 Refactor __main__ logic
Most of this is just de-pyramiding the code, removing else clauses that
are unneeded (or making the if such that the else is not needed).
Rationale is simple, every level of indentation adds more that the
reader needs to keep track of.
2020-07-24 13:45:17 +01:00
A_D 5583486589 replace list literals with tuples
Tuples ensure that this isnt changed at runtime
2020-07-24 13:45:17 +01:00
A_D 6b73161cae Replace AssertionErrors with ValueError
AssertionError comes from `assert`s, using it for this doesn't make sense as we're complaining about values
2020-07-24 13:45:17 +01:00
A_D a40b085303 replace modulo formatting with .format 2020-07-24 13:45:17 +01:00
A_D ec6a09a06d removed oneline statements 2020-07-24 13:45:17 +01:00
A_D 43ba47ddf9 shortened line 2020-07-24 13:45:17 +01:00
A_D 3df8a1f77b added missing whitespace where needed 2020-07-24 13:45:17 +01:00
A_D 8cd6bf4b93 removed unused import 2020-07-24 13:45:17 +01:00
A_D a38a2420df Add newlines to separate scopes
Newlines between scope changes help you to not get lost when reading
source
2020-07-24 13:45:17 +01:00
A_D 836a27fb96 Fixed code blocks 2020-07-24 13:45:17 +01:00
A_D f3d2098179 Updated docs
Added linting, testing, and new requirements-dev.txt instructions
2020-07-24 13:45:17 +01:00
A_D d9cea74cf7 Create requirements-dev.txt 2020-07-24 13:45:17 +01:00
A_D 836efd0771 Removed dev deps from requirements.txt 2020-07-24 13:45:17 +01:00
A_D d0fbaa6091 Add config for autopep8 2020-07-24 13:45:17 +01:00
A_D c58728821e Add flake8 and autopep8 to requirements.txt 2020-07-24 13:45:17 +01:00
Athanasius ddadaf36f2 Update PLUGINS.md
Adds missing blank line that caused acciental underline/heading
2020-07-24 13:45:17 +01:00
Athanasius f57ee880aa Change \xd7 character to a normal 'x' so that 3.46 EDMC.exe finds newer versions. 2020-07-24 12:59:41 +01:00
Athanasius 4131ab87c6 Release 4.0.3: edmarketconnector.xml updated 2020-07-24 12:55:12 +01:00
Athanasius 5c4ea273f4 Release 4.0.3: ChangeLog.md: Translations status Release/4.0.3 2020-07-24 12:42:47 +01:00
Athanasius c3882705e9 Translations: Update to latest
This includes some having the new 'Use alternate URL method' phrase.
2020-07-24 12:37:17 +01:00
Athanasius cb0c65d947 Release 4.0.3: ChangeLog - fully cite shipyard.html location 2020-07-24 12:21:28 +01:00
Athanasius a67d0488d0 Release 4.0.3: ChangeLog - tweak Linux ~ text 2020-07-24 12:16:47 +01:00
Athanasius 93e4adb8c7 Release 4.0.3: Version and ChangeLog 2020-07-24 12:07:42 +01:00
Athanasius 5fb6e49690 Changelog.md: Fix missing % in LOCALDATAAPP ready for 4.0.3 2020-07-23 20:25:55 +01:00
Athanasius d06104ec6e Release 4.0.3-rc3: ChangeLog and version string Release/4.0.3-rc3 2020-07-23 15:02:56 +01:00
Athanasius 0135c73f6f Merge branch 'fix/614-ship-name-underscore' into release-4.0.3-rc3 2020-07-23 14:43:15 +01:00
Athanasius f9de137105 Add import of os.path.expanduser 2020-07-23 14:40:53 +01:00
Athanasius b61645ab06 shipyard: Add UI to toggle option for alternate URL opening
* Added checkbox next to shipyard choice dropdown.
* Also a TODO for using an incrementing 'row' variable throughout.
2020-07-23 14:36:02 +01:00
A_D 99014dd970 Added a config to use the new file based shipyard
This also reverts commenting out the old solution for long URLs
2020-07-23 14:36:02 +01:00
A_D b818922193 Fixed issues with super long links for shipyards
This works by creating a temp file at config.app_dir and storing the
link in there, followed by directing the local browser to open the file.

HTML meta tags are then used to direct the browser to refresh to a URL
of our choosing (which is HTML escaped, just in case someone tries
something clever)

This should work everywhere, and on any browser (as the file:// format
is defined at https://tools.ietf.org/html/rfc1738 which was posted in
1994).

The URI used (`file://localhost/path`) ensures that we only ever
ask for a localhost file at our path.

The HTML format should be completely compliant with all major browsers
as well, ensuring that behaviour is consistent (assuming they support
HTML meta tags)
2020-07-23 14:36:02 +01:00
A_D aa95573f3d Fix ~ not being expanded on linux 2020-07-23 14:35:57 +01:00