Commit Graph
1713 Commits
Author SHA1 Message Date
Athanasius 8a79efd775 Merge branch 'cleanup/fix-stable-requirements' into main 2020-07-30 08:56:46 +01:00
A_D 8483b04923 Removed keyring dependency
This remove all dependencies on the keyring lib, updates the
requirements.txt to reflect that, and ensures that setup.py does not
attempt to package it.

Any use of the "old" keyring code will now return None and warn about
its deprecation.
2020-07-30 08:52:07 +01:00
Athanasius 837ac588cb Comments out py2exe in requirements-dev.txt as it trips up GitHub Actions
docs/Releasing.md has fuller instructions on getting that specific
pyexe version installed anyway.
2020-07-30 08:52:06 +01:00
Athanasius be6a7bcdc5 Releasing.md: Emphasises that sparkle:version is SemVer string. 2020-07-30 08:51:21 +01:00
Athanasius f849f010e2 Releasing.md: Update 'Known Issues' after a stable release. 2020-07-30 08:51:21 +01:00
A_D 8f7bd53b5c Fixed code blocks 2020-07-30 08:51:21 +01:00
A_D 7de06fb6ef Updated docs
Added linting, testing, and new requirements-dev.txt instructions
2020-07-30 08:51:21 +01:00
A_D aae4aace6c Create requirements-dev.txt 2020-07-30 08:51:21 +01:00
A_D 2fa49210d3 Removed dev deps from requirements.txt 2020-07-30 08:51:21 +01:00
A_D 536f2ff393 Add config for autopep8 2020-07-30 08:51:21 +01:00
A_D 26a94f247b Add flake8 and autopep8 to requirements.txt 2020-07-30 08:51:21 +01:00
Athanasius 9e18dde834 Update PLUGINS.md
Adds missing blank line that caused acciental underline/heading
2020-07-30 08:51:21 +01:00
A_D 1053abaf00 Add TODO regarding type config 2020-07-27 18:26:49 +01:00
A_D c5766b9b33 Dont crash when journal_dir is None
Ensures that journal_dir is always at least an empty string.

Fixes #639
2020-07-27 18:26:49 +01:00
Athanasius 67b295df6b Merge pull request #640 from EDCD/fix/639-crash-linux-unset-journal-dir
Dont crash when journal_dir is None
2020-07-27 18:10:34 +01:00
A_D 6ab4433c59 Add TODO regarding type config 2020-07-27 19:07:54 +02:00
A_D 1b543e5820 Dont crash when journal_dir is None
Ensures that journal_dir is always at least an empty string.

Fixes #639
2020-07-27 18:55:59 +02:00
Athanasius 6ba1f77352 Remove greet-everyone workflow, we've gotten things working now 2020-07-26 23:04:37 +01:00
Athanasius df3f70b7ed Rename to push-checks.yml, don't do PRs
Also commented better at the top
2020-07-26 23:03:23 +01:00
Athanasius 6513db3aca Don't force --show-source in .flake8 !
This was the cause of our flake8-your-pr issue!  It meant that as well
as `--format json` giving JSON output it also got polluted with the raw
string of the source line as well.
2020-07-26 23:03:23 +01:00
Athanasius d65176aed8 Add flake8-json to requirements-dev.txt 2020-07-26 23:03:23 +01:00
Athanasius 8dbb275dca Specify GITHUB_TOKEN for flake8-your-pr via env 2020-07-26 23:03:23 +01:00
Athanasius 63d44bf8d7 Attempt to run "tayfun/flake8-your-pr@master" in PRs. 2020-07-26 23:03:22 +01:00
Athanasius 333ba24db4 Rename to 'what it runs on' prefix 2020-07-26 23:03:06 +01:00
Athanasius e461fa62f6 The configuration must be inside a 'with:' 2020-07-26 23:01:10 +01:00
Athanasius 4a3c74ce5b Use fetch-depth 0 for 'all' on checkout@v2 2020-07-26 23:01:10 +01:00
Athanasius f41eb4fb92 Try A_D's "diff only" flake8 checking 2020-07-26 23:01:10 +01:00
Athanasius 838e55710d Uncomment flake8 part of build in workflow 2020-07-26 23:01:10 +01:00
Athanasius fd78df246a Comments out py2exe in requirements-dev.txt as it trips up GitHub Actions
docs/Releasing.md has fuller instructions on getting that specific
pyexe version installed anyway.
2020-07-26 23:01:10 +01:00
Athanasius a76aae9737 Remove pytest and comment out flake8 for now.
Narrowing down what's working and what isn't in this.
2020-07-26 23:01:10 +01:00
Athanasius 607770f7d4 Add greet-example to github workflows 2020-07-26 20:23:02 +01:00
Athanasius 04fa3fae2c Update python-app.yml
Change to ubuntu-18.04
2020-07-26 18:57:52 +01:00
Athanasius f7968bd0c8 Update python-app.yml
Change name to be more obvious when viewing in Actions.
2020-07-26 18:49:10 +01:00
Athanasius 525baf8b03 Create python-app.yml
Add a GitHub Action to check requirements-dev.txt, flake8, and pytest.
2020-07-26 18:27:24 +01:00
Athanasius 022cc2b4ba Merge branch 'release-4.0.3' into main 2020-07-24 14:32:46 +01:00
Athanasius 4705bb2bd3 Merge branch 'stable' into main 2020-07-24 14:32:06 +01:00
Athanasius 04122b2de6 Releasing.md: Emphasises that sparkle:version is SemVer string. 2020-07-24 14:28:34 +01:00
Athanasius 982e77c38a Use SemVer for sparkle:version
Else it thinks 4.0.3.0 > 4.0.3 and keeps offering the upgrade.
2020-07-24 14:22:11 +01:00
Athanasius 6d40d9dcdf Use SemVer for sparkle:version
Else it thinks 4.0.3.0 > 4.0.3 and keeps offering the upgrade.
2020-07-24 14:20:29 +01:00
Athanasius f027d1fa92 Releasing.md: Update 'Known Issues' after a stable release. 2020-07-24 13:45:18 +01:00
Athanasius 0e1c7dbf95 Translations: Add 'Use alternate URL method' to phrases 2020-07-24 13:45:18 +01:00
A_D d41dc38162 Create Enhancement issue template
closes #599
2020-07-24 13:45:17 +01:00
A_D 783b3c5ce9 clarified docs 2020-07-24 13:45:17 +01:00
A_D 0b2b76a9f5 Replaced write out checks with guard clauses
Guard clauses reduce indentation and help when reading code as they
remove a variable and indentation level that the reader would otherwise
need to keep track of
2020-07-24 13:45:17 +01:00
A_D 05de5b557e Removed repeated int(key)
With the previous formatting changes there is no reason to leave key as
possibly a string anywhere, as it was already being converted to an int
everywhere anyway
2020-07-24 13:45:17 +01:00
A_D 8856cec36f Move file backup code to a method
It was repeated in various places and increased noise
2020-07-24 13:45:17 +01:00
A_D c233fa5ff5 Refactor __main__ logic
Most of this is just de-pyramiding the code, removing else clauses that
are unneeded (or making the if such that the else is not needed).
Rationale is simple, every level of indentation adds more that the
reader needs to keep track of.
2020-07-24 13:45:17 +01:00
A_D 5583486589 replace list literals with tuples
Tuples ensure that this isnt changed at runtime
2020-07-24 13:45:17 +01:00
A_D 6b73161cae Replace AssertionErrors with ValueError
AssertionError comes from `assert`s, using it for this doesn't make sense as we're complaining about values
2020-07-24 13:45:17 +01:00
A_D a40b085303 replace modulo formatting with .format 2020-07-24 13:45:17 +01:00