Confirmed by Snake Man on EDCD Discordin #edmc
Snake Man : looks ok I guess (never done much of these manual imports)
python3 trade.py import ../Daurtu.Panshin.Terminal.2019-09-12T12.29.27.prices
NOTE: Import complete: 93 updated items over 1 stations in 1 systems
Snake Man : trade.py market -vv daurtu/panshin command looks fine too. and trade.py run --cap 500 --cr 20m --ly 12 --fr daurtu/pans gives trading results, looks good indeed
Another str versus bytes issue. We *do* need the .encode('utf-8') in
this case, else it will assume Windows cp1252 encoding which then can't
encode some characters. So we switch to binary file mode instead.
*) Code and imports brought in line with edsy plugin
*) 'Coriolis' now appears in Settings > Configuration > Shipyard
dropdown
*) Confirmed that with this active a valid build opens on coriolis.io
This came to light due to python3 not liking try['StarPos'] =
list(this.coordinates) if this.coordinates was None. As the comment
says these three fields are mandatory, ensure we can actually set them
appropriately, and display an error if not.
NB: Due to, I assume, EDDN relay de-duplication of messages, it's been
difficult to 100% test this. No errors thrown, and stock/release EDMC
also doesn't result in a new message arriving at my EDDN consumer.
First pass utilising 'futurize' to do most of the work.
There's an issue with ur'\"' in l10n.py which I'm not sure how to
properly fix.
This now has errors when hitting the 'Update' button.
We need this in master so that the forthcoming Python 2.7 version that
detects plugins that aren't ready for migration can provide a link to
information about migrating. In the future the 'python3' branch might
have been removed.
* Change instances of 'Marginal' to 'EDCD'. Including github URLs.
* Update SDKPATH and WIXPATH to the latest versions.
* Removes un-necessary attempt at including VCredist file. This isn't
needed on any Windows 10 version that is vaguely current (tested on
1909).
* Adds the following to the EDMarketConnector.wxs <Product Id ...>
section so that any new version definitely replaces any older one:
InstallScope="perMachine"
without this it defaults to a per-user install, and you end up with
the prior Marginal-era EDMC allegedly still installed as well, even
though they're installed into the same path.
See commit 1beca864d362625f983cc9465125124ffada4ae2 in the python3
branch.
* Appends ", 2020 Athanasius" to the copyright notices in setup.py.
This will likely change to ", 2020 EDCD" pending EDCD Council
approval.
This had been listing importlib_metadata, and its dependency zipp,
because it's a dependency of newer 'keyring'. As we're hard-coding an
older 'keyring' without that dependency we don't need to list them here.
* WiX Toolset 3.11.2
* WinSparkle 0.7.0
NB: There's a need for a specific/older version of two python modules:
certifi and keyring, else running EDMarketConnector.exe doesn't work.
Unless I'm mistaken about the source of some necessary software/files,
or someone can only find a later/different version of them, this should
now serve as an easy guide to making EDMC releases.
