A_D
de872cdfa6
Added warning log messages
2020-08-07 15:46:46 +02:00
A_D
7adf522de9
Replaced repeated code with helper function
2020-08-07 15:18:33 +02:00
A_D
a88cb454da
Removed todo related to Horizons
2020-08-07 14:54:43 +02:00
A_D
94418dc4fa
Switched to using pathlib
2020-08-07 14:54:04 +02:00
A_D
17f8433a6a
clarify comment
2020-08-07 14:45:48 +02:00
A_D
237e5ce52d
Replaced subscript and concat with replace() call
2020-08-07 14:43:53 +02:00
A_D
b5d3b89a3c
Added docstrings and further type annotations
2020-08-07 14:39:12 +02:00
A_D
a21280ed3b
reordered imports
2020-08-07 13:32:01 +02:00
A_D
5aa6795773
Type annotate all the things!
2020-08-07 13:20:24 +02:00
A_D
94c4a7b7d0
Replaced static lists with tuples
2020-08-07 13:20:24 +02:00
A_D
cea8ac49ca
Ensured that regexps are raw strings
...
Ensures that there are no weird excaping issues
2020-08-07 13:20:23 +02:00
A_D
e477f89664
removed un-needed object subclass
2020-08-07 13:20:23 +02:00
A_D
3c66ab7246
removed unused imports
2020-08-07 13:20:22 +02:00
A_D
6772c84a5f
fixed names where possible
2020-08-07 13:20:22 +02:00
A_D
c0026cea61
replaced list comps with generators
2020-08-07 13:20:21 +02:00
A_D
c012ebc54e
Replaced modulo-formatting with fstrings
...
Specifically did not replace `somefile.write('%s\n' % some_data)` as
print may change the line endings on some OSes which may not be wanted
2020-08-07 13:20:21 +02:00
A_D
4105662fb5
Cleaned up logic and removed overlong lines
...
Generally for the logic cleanups it was replacing giant list
comprehensions with slightly smaller filter calls. filter() is just
plain cleaner when all you're doing in a list comp is
[x for x in y if somecondition].
2020-08-07 13:20:21 +02:00
A_D
4d0cf4e335
Added scope change newlines
2020-08-07 13:20:20 +02:00
A_D
b186e97747
autoformatted code
2020-08-07 13:20:19 +02:00
Athanasius
4d7b60507c
Merge pull request #664 from A-UNDERSCORE-D/linting/import-order
...
Add flake8-isort for import order
2020-08-07 11:42:49 +01:00
A_D
0be9bb7a6d
renamed pyproject.toml, added flake8-isort
2020-08-06 02:21:27 +02:00
Athanasius
22932a33cc
Merge pull request #651 from A-UNDERSCORE-D/fix/request-hangs-threads
...
Fix request hangs threads on exit
2020-07-31 15:08:21 +01:00
A_D
faac29fe84
Made sure to return super().send()
2020-07-31 15:53:20 +02:00
A_D
81dfbdfb8e
Added timeout_session, made inara use it
...
timeout_session provides two things, TimeoutAdapter, a HTTP adapter
subclass that automatically adds timeouts to all requests, and
new_session, which automatically creates a request.Session with the
adapter in the correct place.
2020-07-31 15:53:20 +02:00
Athanasius
5c7744c595
Merge pull request #650 from EDCD/enhancement/logging-found-plugins
...
Ensure all plugins have correct logging from core code
2020-07-31 14:50:55 +01:00
Athanasius
5eb11d3612
Merge pull request #648 from A-UNDERSCORE-D/cleanup/inara
...
Cleanup inara.py
2020-07-31 14:50:11 +01:00
A_D
21a285e6e9
added some more type hints
2020-07-31 15:47:28 +02:00
A_D
f8d4731472
fixed incorrect indexing
2020-07-31 15:47:27 +02:00
A_D
eba318430a
Removed todos about unused args
2020-07-31 15:47:27 +02:00
A_D
446c812485
replaced oneline logic with multiline
2020-07-31 15:47:26 +02:00
A_D
67a260c07f
added type hints to literals
2020-07-31 15:47:26 +02:00
A_D
9005798862
fixed incorrect comment
2020-07-31 15:47:25 +02:00
A_D
bb1def48cd
replaced list comp with filter
2020-07-31 15:47:25 +02:00
A_D
a699ab062d
fixed station link logic
2020-07-31 15:47:24 +02:00
A_D
e74c5c8ceb
replaced list comp with filter
2020-07-31 15:47:23 +02:00
A_D
820b29f7dd
replace dict(list-comp) with dict comp
2020-07-31 15:47:23 +02:00
A_D
539580e38d
Consistently formatted multi-line add_event calls
2020-07-31 15:47:22 +02:00
A_D
96279cb0af
Replaced repeated entry['event'] with variable
2020-07-31 15:47:21 +02:00
A_D
71ad0f92ac
removed outdated comment
2020-07-31 15:47:21 +02:00
A_D
8e49066ca4
Replaced convoluted or-based logic with terneries
2020-07-31 15:47:20 +02:00
A_D
9db9ed4dfc
Cleaned up overlong lines
2020-07-31 15:47:19 +02:00
A_D
13c2679c38
Added spacing around scope changes
2020-07-31 15:47:19 +02:00
A_D
160013e3e5
Added type annotations and docstrings
2020-07-31 15:47:18 +02:00
A_D
eec4c2ebd6
autoformat with autopep8
2020-07-31 15:47:18 +02:00
Athanasius
3a31139cbd
Correct frame_info type
2020-07-31 14:46:38 +01:00
Athanasius
efe63ceac9
Refactor caller_attributes() code into separate methods
...
* find_caller_frame() to do the frame walk.
* munge_module_name() to fix up for plugins.
NB: caller_attributes() now has a noqa on CCR001 as I don't think it
can sensibly be made any less complex. Pulling out the 'if frame:'
section just results in *that* new method then being labelled as too
complex.:244
2020-07-31 14:46:38 +01:00
Athanasius
282e3ddbc5
Fix up and expand on docstrings.
2020-07-31 14:46:38 +01:00
Athanasius
657253b3e3
Set internal and found plugin module_name separately.
...
* Settled on `plugins.internal` and `<plugins>.found` as the format.
* A PyCharm recommendation was to use 'cls' instead of 'self' on class
methods, so the class detection code needs to cater for that.
Technically a developer could use any string for the "myself" member
name, but we'll assume just these two.
* Found will always have at least one folder level within plugin_dir
* Internal should always have *no* folder within internal_plugin_dir,
but cater for it just in case in future.
2020-07-31 14:46:38 +01:00
Athanasius
89f2726e48
Set internal and found plugin module_name separately.
...
Settled on `plugins.<internal` and `<plugins>.found` as the format.
2020-07-31 14:46:38 +01:00
Athanasius
ad021e0765
Remove %(class)s from logging format as un-necessary.
...
It was only there to test the code populating it.
2020-07-31 14:46:38 +01:00
