ED/EDMarketConnector
1
0
Fork 0
mirror of https://github.com/EDCD/EDMarketConnector.git synced 2025-04-24 20:50:53 +03:00
Code Issues Projects Releases Wiki Activity
1,837 Commits 16 Branches 276 Tags
Commit Graph

1837 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Athanasius
e3b01f6c58 Remove non-existent dependency 2020-07-29 15:00:39 +01:00
Athanasius
9f860a5990 Check if a conditional is needed on all steps 
Basically, if it's only on the first and fails, then do the others
still run ?
 2020-07-29 15:00:39 +01:00
Athanasius
912f82ce38 Needs a runs-on for the check_access 2020-07-29 15:00:39 +01:00
Athanasius
b40ee96755 Correct syntax 2020-07-29 15:00:39 +01:00
Athanasius
6c9bffcaa0 Don't run flake8_annotate if no access 
This is using github.actor and checking who it is.  If they're not
someone who should have access then use a run with 'exit 1' to fail the
check job.

Then flake8_annotate job needs check_access to have succeeded.

This *will* flag the workflow action as failed if no access, hopefully
it will be obvious why.

Using 'AthanasiusTEST' so it fails for me on this commit/push.
 2020-07-29 15:00:39 +01:00
Athanasius
dc58d0f3af S I N G L E Q U O T E S 2020-07-29 15:00:39 +01:00
Athanasius
09e39a47ef Attempt to limit flake8 annotations to Athanasius 2020-07-29 15:00:39 +01:00
Athanasius
ed9a4cfe29 Revert "Cause EDMC.py to diff to check the detection" 
This reverts commit 3b55a7a5deb009fac48b021602a074e3345afed2.
 2020-07-29 15:00:39 +01:00
Athanasius
9a5884b57d Cause EDMC.py to diff to check the detection 2020-07-29 15:00:39 +01:00
Athanasius
24cf445254 Gurantee exit 0 AND fix the echo 
* GH Workflows run under "/bin/bash -e", which means if anything in it
 fails it all exits immediately.  So append " || true" to the egrep.
* The echo to magically set the env var back in the workflow needs to
 use "" not '' else the in-shell variable won't interpolate.
 2020-07-29 15:00:39 +01:00
Athanasius
40dc913367 *.py check should always exit 0 2020-07-29 15:00:39 +01:00
Athanasius
a548d383a3 Single quotes then ? 2020-07-29 15:00:39 +01:00
Athanasius
a93cfb5ed8 Try ENV var for passing presence of *.py files 
This uses <https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#using-workflow-commands-to-access-toolkit-functions>
to set PYFILES env var globally in the job, so should be testable in
the following steps.
 2020-07-29 15:00:39 +01:00
Athanasius
792583bfe1 *.py exit status was inverted 
That'll teach me for testing with a commit only affecting *.yml files.
 2020-07-29 15:00:39 +01:00
Athanasius
9c413a8ba9 Remove extraneous 'needs:' 2020-07-29 15:00:39 +01:00
Athanasius
dff1e3bce2 Do *.py check as step in flake8_annotate 
And make both the 'Annotate with Flake8' and 'Set up Python 3.7' steps
dependent on it.
 2020-07-29 15:00:39 +01:00
Athanasius
3ae0b83ac2 Only run flake8 annotation if there are *.py files in diff 2020-07-29 15:00:39 +01:00
Athanasius
629a3461f6 Final clean ups. 
It works!  So, yes, need refs/remotes/origin/ prepended to the base_ref,
which will always be a branch for a PR.

* Remove debug lines (set -x, etc).
* No need for pytest here as yet.
* Fall back to requirements.txt if no requirements-dev.txt.
 2020-07-29 15:00:39 +01:00
Athanasius
648c1af339 See if prepending "refs/remotes/origin/" helps 2020-07-29 15:00:39 +01:00
Athanasius
f2fa489819 Attempt "git diff <branch> --" 
As in "git diff [<options>] [<commit>] [--] [<path>...]", in case
it's an ambiguity rather than not knowing what 'develop' is.
 2020-07-29 15:00:39 +01:00
Athanasius
4a965bb7c9 Extra git commands for diagnosis 2020-07-29 15:00:39 +01:00
Athanasius
3f97588ab6 Try "fetch-depth: 0" on the extra checkouts 2020-07-29 15:00:39 +01:00
Athanasius
18ff1c0e3f Add 'set -x' to get feedback on all bash commands run 2020-07-29 15:00:39 +01:00
Athanasius
d36e213ae2 Correct "-name" -> "- name" 2020-07-29 15:00:39 +01:00
Athanasius
3ad8bd6cc8 pr-checks: Changed to pull_request and fleshed out 
* Name all steps
* After checkout@v2 fetch: 1) checkout base_ref, 2) checkout head_ref
* Set and use BASE_REF env var
 2020-07-29 15:00:39 +01:00
Athanasius
56e33d20d6 Copy push-checks.yml to pr-checks.yml 2020-07-29 15:00:39 +01:00
Athanasius
755e401df8 Revert "Change the push-checks back into also PRs." 
This reverts commit 4da1d9df4ed14909574a69c70d7d0dd3d228e529.
 2020-07-29 15:00:39 +01:00
A_D
ce4149efd5 Added debug logs 2020-07-29 14:58:17 +01:00
Athanasius
68955e0070
Merge pull request #644 from A-UNDERSCORE-D/enhancement/remove-keyring 
Enhancement/remove keyring
 2020-07-29 14:50:54 +01:00
Athanasius
a3ea7008b4
Merge pull request #646 from EDCD/enhancement/638-flake8-prs 
Run flake8 for status on all pull requests
 2020-07-28 13:49:07 +01:00
Athanasius
4da1d9df4e Change the push-checks back into also PRs. 
Renamed to suit.
 2020-07-28 13:45:55 +01:00
Athanasius
525ebae61d
Merge pull request #625 from A-UNDERSCORE-D/fix/624-inara-too-fast 
Switched to using a timer for inara updates
 2020-07-28 11:26:51 +01:00
A_D
9d2548c70b
Removed keyring dependency 
This remove all dependencies on the keyring lib, updates the
requirements.txt to reflect that, and ensures that setup.py does not
attempt to package it.

Any use of the "old" keyring code will now return None and warn about
its deprecation.
 2020-07-28 11:24:49 +02:00
Athanasius
cbb64a60a8
Merge pull request #636 from EDCD/cleanup/EDMarketConnector.py 
Continuing work on passing flake8 in EDMarketConnector.py
 2020-07-27 18:35:11 +01:00
Athanasius
b1d35e0579 Merge branch 'fix/639-crash-linux-unset-journal-dir' into develop 2020-07-27 18:12:40 +01:00
A_D
6ab4433c59
Add TODO regarding type config 2020-07-27 19:07:54 +02:00
A_D
1b543e5820
Dont crash when journal_dir is None 
Ensures that journal_dir is always at least an empty string.

Fixes #639
 2020-07-27 18:55:59 +02:00
Athanasius
a5b7bea2ca Move comment to line above if 2020-07-27 15:16:23 +01:00
Athanasius
b17b3a4a72
Merge pull request #632 from A-UNDERSCORE-D/cleanup/eddb 
Cleanup eddb plugin
 2020-07-27 14:56:29 +01:00
A_D
b27e4a3628
fixed tk import and type annotations 2020-07-27 15:15:56 +02:00
A_D
cad5f72b0a
updated type annotation 2020-07-27 15:15:55 +02:00
A_D
7b231fb244
removed unicode specifier from string 
python3 strings are always unicode
 2020-07-27 15:15:55 +02:00
A_D
07c43d3057
added type annotations to globals 2020-07-27 15:15:54 +02:00
A_D
e0462d8719
Replaced complex oneliner with multiline if 2020-07-27 15:15:54 +02:00
A_D
37181264c9
Added newline after scope changes 2020-07-27 15:15:53 +02:00
A_D
4eed4404c6
Added Any type hint to this 
Resolves most type warnings
 2020-07-27 15:15:53 +02:00
A_D
ab58aa6355
autoformatted file 2020-07-27 15:15:52 +02:00
A_D
d4299c224f
dont force a send on exit 
just try and send if we can
 2020-07-27 15:12:32 +02:00
A_D
bb817eee3b
removed outdated comment 2020-07-27 15:08:47 +02:00
A_D
340f8928b3
switched to using config for last update time 2020-07-27 15:08:47 +02:00