Commit Graph
1914 Commits
Author SHA1 Message Date
A_D eec4c2ebd6 autoformat with autopep8 2020-07-31 15:47:18 +02:00
Athanasius 3dab0e9d91 Comment pr-check flake8, and don't --exit-zero the full check 2020-07-31 14:44:44 +01:00
Athanasius 46e9f4253d Merge pull request #654 from Athanasius/fix/638-annotate-flake8-checks
flake8-your-pr annotations fail for any fork branch
2020-07-31 14:21:13 +01:00
Athanasius 4aa841c6e2 Will PY file check work if env.PYFILES not set at all ? 2020-07-31 13:59:52 +01:00
Athanasius 67a13d3869 Change Checkout conditional to direct context, not env vars 2020-07-31 13:56:18 +01:00
Athanasius e087cd7f85 Comment that 'env' for another commit 2020-07-31 13:53:23 +01:00
Athanasius ecf4732e44 Check step needs a 'uses' or 'run', so add latter with 'env' for check 2020-07-31 13:51:50 +01:00
Athanasius 1352931465 Remove EDMCLogging.py comment to trigger diff 2020-07-31 13:50:27 +01:00
Athanasius 937dacd7ca Implement "same owner?" check for base/head
* Also updates top comment.
2020-07-31 13:47:40 +01:00
Athanasius 3972abbace Comment out the current steps 2020-07-31 13:42:00 +01:00
Athanasius b75e2ec2b1 Comment about the check being wrong
This gets the branch rolling for a PR
2020-07-31 13:36:49 +01:00
Athanasius f2cfa6ca1d Merge pull request #653 from Athanasius/fix/652-PR-Checks-forked-branch
Fixing PR-Checks for forked branches
2020-07-31 13:31:11 +01:00
Athanasius 64e6ad439c Try remote-add/fetch in separate step 2020-07-31 13:28:28 +01:00
Athanasius 8d7f91248d Oops, moved the 'steps:' line too 2020-07-31 13:18:46 +01:00
Athanasius 063a83b8e8 Move 'Show github context' to just before flake8
$GITHUB_EVENT_PATH wasn't set in the shell with it first.
2020-07-31 13:17:56 +01:00
Athanasius 71fa1dbcf6 Comment the 'add base remote and fetch it' 2020-07-31 13:15:52 +01:00
Athanasius 3d46f23fc7 Need svn_url, not url
'url' is api.github.com
2020-07-31 13:07:40 +01:00
Athanasius 895376c039 Try manually adding remote and fetching to get the refs
Also, add 'end' to 'Show github context'
2020-07-31 13:05:20 +01:00
Athanasius 62fe9deae7 repo.owner.login not repo.full_name 2020-07-31 12:57:44 +01:00
Athanasius e1a5a1f811 Top-level event key needs to be pull_request 2020-07-31 12:51:07 +01:00
Athanasius 7c00ddcebf We want github.context for the full info 2020-07-31 12:40:38 +01:00
Athanasius 2fa10b4a9e Correct setting of BASE_REPO 2020-07-31 12:35:54 +01:00
Athanasius c5d43a4ada Try a whole new method of referring to 'base', and checkout 'head' 2020-07-31 12:34:12 +01:00
Athanasius 92ea8943df Run 'Show github context' as first step 2020-07-31 12:21:32 +01:00
Athanasius a01c36f660 Correct "-run:" to "run:" 2020-07-31 12:20:12 +01:00
Athanasius 015a50d53f Fix small typo "-name" -> "- name" 2020-07-31 12:18:05 +01:00
Athanasius 43ae6dde61 Restore changes, draft status was to blame ? 2020-07-31 12:15:15 +01:00
Athanasius 91e07a62eb Revert pr-checks.yml to see if it runs again 2020-07-31 12:12:53 +01:00
Athanasius 5d7612b0db Move comment, was it stopping any steps from being defined? 2020-07-31 12:09:05 +01:00
Athanasius e430246d5b Add comment to trigger change 2020-07-31 12:07:52 +01:00
Athanasius 9259afd344 Add display of entire github context 2020-07-31 11:58:13 +01:00
Athanasius 0115e5c6ba PLUGINS.md: except not catch 2020-07-30 14:33:00 +01:00
Athanasius 2df930b9d3 Merge branch 'enhancement/main-plugins-logging' into develop 2020-07-30 14:21:03 +01:00
Athanasius 0e6d4468da PLUGINS.md: Fix typo ' -> ` 2020-07-30 14:17:14 +01:00
Athanasius 974872fe9e PLUGINS.md: Logging is being added, how to prepare
* Currently you use `print(...)`
* `logging` support is coming, here's how to prepare.
2020-07-30 14:05:09 +01:00
Athanasius 8a79efd775 Merge branch 'cleanup/fix-stable-requirements' into main 2020-07-30 08:56:46 +01:00
A_D 8483b04923 Removed keyring dependency
This remove all dependencies on the keyring lib, updates the
requirements.txt to reflect that, and ensures that setup.py does not
attempt to package it.

Any use of the "old" keyring code will now return None and warn about
its deprecation.
2020-07-30 08:52:07 +01:00
Athanasius 837ac588cb Comments out py2exe in requirements-dev.txt as it trips up GitHub Actions
docs/Releasing.md has fuller instructions on getting that specific
pyexe version installed anyway.
2020-07-30 08:52:06 +01:00
Athanasius be6a7bcdc5 Releasing.md: Emphasises that sparkle:version is SemVer string. 2020-07-30 08:51:21 +01:00
Athanasius f849f010e2 Releasing.md: Update 'Known Issues' after a stable release. 2020-07-30 08:51:21 +01:00
A_D 8f7bd53b5c Fixed code blocks 2020-07-30 08:51:21 +01:00
A_D 7de06fb6ef Updated docs
Added linting, testing, and new requirements-dev.txt instructions
2020-07-30 08:51:21 +01:00
A_D aae4aace6c Create requirements-dev.txt 2020-07-30 08:51:21 +01:00
A_D 2fa49210d3 Removed dev deps from requirements.txt 2020-07-30 08:51:21 +01:00
A_D 536f2ff393 Add config for autopep8 2020-07-30 08:51:21 +01:00
A_D 26a94f247b Add flake8 and autopep8 to requirements.txt 2020-07-30 08:51:21 +01:00
Athanasius 9e18dde834 Update PLUGINS.md
Adds missing blank line that caused acciental underline/heading
2020-07-30 08:51:21 +01:00
Athanasius 3b87df17af Tweak EDMarketConnector.py startup so the redirect is first
* Don't want any output until the redirect is done when running frozen.
* Make the line buffering in the redirect more obvious.
2020-07-29 15:02:47 +01:00
Athanasius 4ecb4f573a 2 lines after def test_logging() 2020-07-29 15:02:47 +01:00
Athanasius 45ef87bcb4 Correct frame typing, and import clean up.
Also explains why we're doing that _getframe import that way.
2020-07-29 15:02:47 +01:00