e280d6c283
This fixes an apparently harmless bug in the `openurl()` function defined in this module (it's not part of the class). 1. On `win32` lookup the user setting for opening HTTPS URLs. 2. If that doesn't look like IE or Edge... 3. Set `cls` to the value for that. 4. Now look up the 'use this command' for *that* ... 5. And if it doesn't have `iexplore` in it... 6. Use `subprocess.Popen()` to invoke that browser with the given URL. The problem is that step 6 still tries to use `buf.value`. But `buf` is no longer present as it was from before 5989acd0d3263e54429ff99769ff73a20476d863 changed over to `winreg`. It should be just `value` from the winreg calls. That exception is then caught and ignored, and it ends up just running `webbrowser.open(url)` anyway. To be honest, this feels like we should just make this an unconditional call to `webbrowser.open(url)` now, given apparently no-one's complained about it always actually using that not working for them. Given Edge is Chrome-based now, and any supported OS should have Edge, Chrome or Firefox (OK, maybe Safari and some others) as the HTTPS browser, I don't see this being an issue.
Any questions or offers of help can be directed to the EDCD Discord #edmc channel:
Elite: Dangerous Market Connector (EDMC)
This application is only of use to PC players of the game Elite Dangerous (and its expansions). It won't work with PS4 or Xbox accounts.
It utilises the Journal files written by the game on the user's computer, together with data from the API Frontier Developments supplies in order to feed this data to various third party sites that the user may find useful.
See the Wiki documentation for more details.
Installation & Uninstall
Please see the Installation & Setup wiki page.
Running from source
Please see the Running from source wiki page.
Plugins
Plugins extend the behaviour of this app. See the Plugins wiki page for more information.
If you would like to write a plugin please see PLUGINS.md.
Troubleshooting
Please see the Troubleshooting wiki page.
Reporting a problem
Please report a problem as a new GitHub issue. See Reporting a problem for further guidance, including how to find the necessary log files to attach to the report.
Packaging for distribution
Please see docs/Releasing.md.
Disclaimer
This app uses the “Companion” web API that Frontier originally supplied for their Elite Dangerous iOS app and now support for third-party apps. If that API ceases to function in the future then much of this application's functionality will be curtailed (although it could still utilise Journal files).
Acknowledgements
Please see the Acknowledgements wiki page.
License
Copyright © 2015-2019 Jonathan Harris, 2020-2021 EDCD
Licensed under the GNU Public License (GPL) version 2 or later.