Commit Graph
1801 Commits
Author SHA1 Message Date
Adrian Ulrich 2e9dca4505 fix grey theme 2017-06-21 20:32:00 +02:00
Adrian Ulrich 578ae2d75f miniplaybackactivity should use match_parent.
wrap_content is just wrong and makes it look bad in horizontal view.
2017-06-21 19:56:31 +02:00
Adrian Ulrich 884c5ec491 Fix MiniPlaybackActivity
The PopupWindow style does not inherit from VanillaBase, so we must pass the bare minimum to it.
2017-06-21 19:47:48 +02:00
Adrian Ulrich 94b7566881 Handle KEYCODE_SEARCH 2017-06-19 19:07:11 +02:00
Adrian Ulrich b9f0d2db88 force use of index on left joins to song-contributors.
SQLite versions on Android 4.x fail to pick up the index, resulting in a full table scan which is pretty horrible for performance.
We therefore change the views to force sqlite using the index.
2017-06-19 18:55:29 +02:00
Adrian Ulrich 7612febbab improve media dirs detection on newer android releases.
use getExternalMediaDirs() if available instead of guessing the path to the sd-card.
2017-06-18 18:23:08 +02:00
Adrian Ulrich 3a43622f41 fix color 2017-06-18 18:02:29 +02:00
Adrian Ulrich bd198012ed Create issue_template.md 2017-06-18 12:50:08 +02:00
Adrian Ulrich 881873eafd update translations 2017-06-12 18:53:31 +02:00
Adrian Ulrich 64d0325a7d update about.html 2017-06-12 18:48:42 +02:00
Adrian Ulrich 1c7142e12c bump version 2017-06-10 13:13:50 +02:00
Adrian Ulrich 124a24e9b1 update widget previews 2017-06-10 13:10:04 +02:00
Adrian Ulrich 47a3e9a7ee Update widget_{play,pause} 2017-06-10 12:54:52 +02:00
Adrian Ulrich 012b53e1ea also blacklist .tmp and .bin files 2017-06-10 12:38:01 +02:00
Adrian Ulrich 3481503633 Support for adding any content:// style URI 2017-06-10 12:31:26 +02:00
Adrian Ulrich 9cdce55d95 upate play/pause icons 2017-06-09 23:17:34 +02:00
Adrian Ulrich efb107b063 Fix context menues inside SlidingView for Android 7.x 2017-06-09 23:13:49 +02:00
Adrian Ulrich c2ed38f0af Fix out of bounds error.
We might call timeline.add() with an invalid position if we skipped a song due to being unfilled.
Use 'added' instead of 'j' to calculate the queue position.
2017-06-09 09:37:03 +02:00
Adrian Ulrich 38cbce6d78 center holo divider
Android 4.x defaults to an inset of 10dip on the right side.
2017-06-08 15:22:45 +02:00
Adrian Ulrich e74180f62b Display total amount of play time in stats. 2017-06-08 15:13:38 +02:00
Adrian Ulrich db02f11963 Minor design tweaks. 2017-06-08 14:56:07 +02:00
Adrian Ulrich 754f53776a Use same dimensions for Holo and Material design. 2017-06-08 14:53:38 +02:00
Adrian Ulrich a1252fd2d6 bump DB version and trigger a full clean 2017-06-08 14:01:57 +02:00
Adrian Ulrich d6b1da50fb Fix renames
We failed to fully remove any orphaned artists, albums references, this could result in duplicate items showing up in the songs view.
2017-06-08 11:18:02 +02:00
Adrian Ulrich 981b22764f Nuke invalid song references
If a song somehow ends up with multiple artist, album entries, the view will show the song multiple times (each possible combination).

This is - confusing - and such a song should not exist. We are now deleting such entries during cleanups.
2017-06-07 21:53:38 +02:00
Adrian Ulrich 57992bad25 Add background circle to play button 2017-06-07 14:41:08 +02:00
Adrian Ulrich aabd677a52 more icon updates 2017-06-07 13:16:23 +02:00
Adrian Ulrich 4d77cad1d8 next icon update batch
control buttons
2017-06-07 13:11:41 +02:00
Adrian Ulrich 983fd4dfc3 next batch of icon updates 2017-06-07 13:07:57 +02:00
Adrian Ulrich f980395e3b Allow newlines in tags 2017-06-07 12:27:05 +02:00
Adrian Ulrich 3a421e7a39 Add missing cursor != null check.
Samsung seems to return a null cursor instead of throwing a SecurityException.
2017-05-31 18:37:59 +02:00
Adrian Ulrich 8f7dff2550 also use new style in widget_{next,previous} icons 2017-05-14 11:22:49 +02:00
Adrian Ulrich 72fffca5cc first batch of icon upgrades 2017-05-14 11:14:22 +02:00
Adrian Ulrich 0b9bbe99d6 change dpi export settings to work with inkscape 0.92 2017-05-14 10:32:25 +02:00
Adrian Ulrich e0b0232621 draw note as default cover 2017-05-10 21:46:37 +02:00
Adrian Ulrich e3888d8b02 use new fallback cover 2017-05-06 12:10:06 +02:00
Adrian Ulrich 36aefb486f add missing SVG 2017-05-01 09:27:24 +02:00
Adrian Ulrich dce63a6473 Sort by disc,track for mtime and playcount
Songs with the same mtime are likely in the same album, so sorting by disc and track doesn't hurt, especially as we sort by disc,track by default anyway when returning songs.
We also do the same for playcount sortings because we can.
2017-05-01 09:20:51 +02:00
Adrian Ulrich fdfa72d09d target 1.0.52 2017-04-27 19:20:56 +02:00
Adrian Ulrich 6096bed5e6 fix shuffle for 'play as next'
The old code did not use the correct offsets, we now make sure to
pass the correct (= changed) range to the shuffle function.
2017-04-24 19:49:36 +02:00
Adrian Ulrich 303f9d2375 implement KEEP_SCREEN_ON 2017-04-24 19:16:43 +02:00
Adrian Ulrich b792afcd7b Do not show dragger for filesystem view.
The icon already indicates the purpose of the row
2017-04-24 19:02:57 +02:00
Adrian Ulrich c364875b71 Avoid jumps during rescan 2017-04-24 19:02:48 +02:00
Adrian Ulrich f04a2f1186 Catch strange SecurityException.
No idea how people manage to hit this, but it seems to be a thing on Samsung phones.

Sample stacktrace:
java.lang.SecurityException: Permission Denial: reading com.android.providers.media.MediaProvider uri content://media/external/audio/media from pid=12655, uid=10269 requires android.permission.READ_EXTERNAL_STORAGE, or grantUriPermission()
	at android.os.Parcel.readException(Parcel.java:1620)
	at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:183)
	at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:135)
	at android.content.ContentProviderProxy.query(ContentProviderNative.java:421)
	at android.content.ContentResolver.query(ContentResolver.java:502)
	at android.content.ContentResolver.query(ContentResolver.java:445)
	at ch.blinkenlights.android.vanilla.MediaUtils.getAndroidMediaIds(MediaUtils.java:591)
	at ch.blinkenlights.android.vanilla.PlaybackService.scrobbleBroadcast(PlaybackService.java:1108)
	at ch.blinkenlights.android.vanilla.PlaybackService.broadcastChange(PlaybackService.java:1064)
	at ch.blinkenlights.android.vanilla.PlaybackService.handleMessage(PlaybackService.java:1543)
	at android.os.Handler.dispatchMessage(Handler.java:98)
	at android.os.Looper.loop(Looper.java:148)
	at android.os.HandlerThread.run(HandlerThread.java:61)

Note that this happens WHILE we play a song - so claiming to not have READ_EXTERNAL_STORAGE privileges seems to be - strange.
2017-04-22 18:37:35 +02:00
Adrian Ulrich df49dd1a49 fix possible NPE
We register ourselfs as a callback receiver BEFORE the adapter has been created.
This crash is unlikely but happens once in a while according to the play store.
2017-04-22 18:30:25 +02:00
Adrian Ulrich 07a0a1a81a update changelog 2017-04-22 18:18:21 +02:00
Adrian Ulrich 46a8d0b602 improve full rescans to include skip and playcounts, also makes things nicer to read. 2017-04-22 18:13:21 +02:00
Adrian Ulrich 4f509303de preserve playcounts during updates 2017-04-22 17:26:38 +02:00
Adrian Ulrich 50ae82446e Nag if user tries to edit directories
But start scan only if it changed
2017-04-22 17:02:05 +02:00
Adrian Ulrich 0c3e000624 disable context menu for 'up' row 2017-04-22 16:27:38 +02:00