mirror of
https://github.com/navidrome/navidrome.git
synced 2025-05-08 14:21:09 +03:00
fix: remove remaining releaseDate references in SongDatagrid
Cleaned up leftover `releaseDate` references in `SongDatagrid.jsx`: - Removed `releaseDate` parameter and usage from `handlePlaySubset` in `DiscSubtitleRow`. - Removed `releaseDate` prop passed to `AlbumContextMenu` in `DiscSubtitleRow`. - Removed `releaseDate` from the drag item data in `SongDatagridRow`. - Removed `releaseDate` parameter and the corresponding `else` block from the `playSubset` function in `SongDatagridBody`. This ensures the component consistently uses `discNumber` for grouping and playback actions initiated from the disc subtitle, fully resolving the inconsistencies related to issue #3720.
This commit is contained in:
parent
b782f50589
commit
854023df0a
@ -63,8 +63,8 @@ const DiscSubtitleRow = forwardRef(
|
|||||||
({ record, onClick, colSpan, contextAlwaysVisible }, ref) => {
|
({ record, onClick, colSpan, contextAlwaysVisible }, ref) => {
|
||||||
const isDesktop = useMediaQuery((theme) => theme.breakpoints.up('md'))
|
const isDesktop = useMediaQuery((theme) => theme.breakpoints.up('md'))
|
||||||
const classes = useStyles({ isDesktop })
|
const classes = useStyles({ isDesktop })
|
||||||
const handlePlaySubset = (releaseDate, discNumber) => () => {
|
const handlePlaySubset = (discNumber) => () => {
|
||||||
onClick(releaseDate, discNumber)
|
onClick(discNumber)
|
||||||
}
|
}
|
||||||
|
|
||||||
let subtitle = []
|
let subtitle = []
|
||||||
@ -79,7 +79,7 @@ const DiscSubtitleRow = forwardRef(
|
|||||||
<TableRow
|
<TableRow
|
||||||
hover
|
hover
|
||||||
ref={ref}
|
ref={ref}
|
||||||
onClick={handlePlaySubset(record.releaseDate, record.discNumber)}
|
onClick={handlePlaySubset(record.discNumber)}
|
||||||
className={classes.row}
|
className={classes.row}
|
||||||
>
|
>
|
||||||
<TableCell colSpan={colSpan}>
|
<TableCell colSpan={colSpan}>
|
||||||
@ -92,7 +92,6 @@ const DiscSubtitleRow = forwardRef(
|
|||||||
<AlbumContextMenu
|
<AlbumContextMenu
|
||||||
record={{ id: record.albumId }}
|
record={{ id: record.albumId }}
|
||||||
discNumber={record.discNumber}
|
discNumber={record.discNumber}
|
||||||
releaseDate={record.releaseDate}
|
|
||||||
showLove={false}
|
showLove={false}
|
||||||
className={classes.contextMenu}
|
className={classes.contextMenu}
|
||||||
hideShare={true}
|
hideShare={true}
|
||||||
@ -128,7 +127,6 @@ export const SongDatagridRow = ({
|
|||||||
discs: [
|
discs: [
|
||||||
{
|
{
|
||||||
albumId: record?.albumId,
|
albumId: record?.albumId,
|
||||||
releaseDate: record?.releaseDate,
|
|
||||||
discNumber: record?.discNumber,
|
discNumber: record?.discNumber,
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
@ -204,16 +202,10 @@ const SongDatagridBody = ({
|
|||||||
const { ids, data } = rest
|
const { ids, data } = rest
|
||||||
|
|
||||||
const playSubset = useCallback(
|
const playSubset = useCallback(
|
||||||
(releaseDate, discNumber) => {
|
(discNumber) => {
|
||||||
let idsToPlay = []
|
let idsToPlay = []
|
||||||
if (discNumber !== undefined) {
|
if (discNumber !== undefined) {
|
||||||
idsToPlay = ids.filter(
|
idsToPlay = ids.filter((id) => data[id].discNumber === discNumber)
|
||||||
(id) =>
|
|
||||||
data[id].releaseDate === releaseDate &&
|
|
||||||
data[id].discNumber === discNumber,
|
|
||||||
)
|
|
||||||
} else {
|
|
||||||
idsToPlay = ids.filter((id) => data[id].releaseDate === releaseDate)
|
|
||||||
}
|
}
|
||||||
dispatch(
|
dispatch(
|
||||||
playTracks(
|
playTracks(
|
||||||
|
Loading…
x
Reference in New Issue
Block a user