Commit Graph
2250 Commits
Author SHA1 Message Date
Athanasius 477ea5be42 Merge pull request #716 from A-UNDERSCORE-D/cleanup/prefs
Cleanup/prefs
2020-09-22 17:03:26 +01:00
Athanasius 20464b80c7 Merge branch 'develop' into cleanup/prefs 2020-09-22 16:59:44 +01:00
Athanasius 4cec46b028 Pre-Release 4.1.0-beta6 pre-prefs-merge Release/4.1.0-beta6 2020-09-22 16:30:49 +01:00
Athanasius a3b69fd94d Switch internal plugins to EDMCLogging.get_main_logger() 2020-09-22 16:20:05 +01:00
Athanasius 29d5bb7c35 Merge pull request #715 from EDCD/fix/711-utf8-locale
Use manifests for UTF-8, including in EDMC.py
2020-09-22 16:17:36 +01:00
Athanasius 7750bbdf4a Move GUI/CLI conditional into get_plugin_logger()
It's cleaner here than in the calling plug.py code.
2020-09-22 16:09:39 +01:00
Athanasius fa326ad3d3 EDMC.py: Move DEBUG logging to after level is set. 2020-09-22 15:54:18 +01:00
Athanasius 14b8565aff Add 'import logging' (back in?) to prefs.py 2020-09-22 15:50:06 +01:00
Athanasius 3759f2f0f2 Use appropriate base logger name for plugins. 2020-09-22 15:48:09 +01:00
Athanasius a883eb29b2 plug.py, prefs.py: Use get_main_logger() 2020-09-22 15:44:16 +01:00
Athanasius 22b3362c20 companion.py: Switch to using EDMCLogging.get_main_logger()
So that we use the correct one for GUI versus CLI.
2020-09-22 15:37:56 +01:00
Athanasius edc6ed6596 Add locale DEBUG logging to EDMC.py 2020-09-22 15:37:45 +01:00
Athanasius c0b01f88ac Add get_main_logger() method to EDMCLogging.py
This is so the decision on appname versus appcmdname is in one place.
2020-09-22 15:35:42 +01:00
Athanasius 0f3ebd6e23 Add a manifest for EDMC.exe so that it also runs UTF-8 2020-09-22 15:34:35 +01:00
Athanasius 9e1ffc14c8 setup.py: Reference EDMC.manifest ready for its creation
We'll want to do the same "use the UTF-8 codepage" thing here.
2020-09-22 14:54:39 +01:00
Athanasius a308171bfc Remove plugintest/miggytest.db
I swear I already did this ....
2020-09-22 14:50:27 +01:00
Athanasius a332aaedd9 Merge pull request #714 from EDCD/enhancement/miggytest-plugin
Now in docs/examples/plugintest
2020-09-22 14:48:01 +01:00
Athanasius ec5b9fc561 Rename miggytest plugin to plugintest.
Also now has docstrings and types, and generally passes flake8 and also
mypy, with the exception of that 'this' hack not being liked.
2020-09-22 14:43:10 +01:00
Athanasius 803a6c31c9 miggytest plugin: Tests "for plugins" modules
This plugin is designed as a quick test that we are supplying the things
we say we will for plugins.

* Check that modules are available: sqlite3, shutil, zipfile.
* Check that logging works as expected.
2020-09-22 14:27:32 +01:00
Athanasius 6c63984aca Merge pull request #708 from A-UNDERSCORE-D/enhancement/example-plugin
Add example plugin and clean up plugin docs
2020-09-22 14:25:15 +01:00
A_D 97d8631e11 Removed todo 2020-09-22 15:22:27 +02:00
A_D 9c3f273027 Added type hints and param descriptions 2020-09-22 15:20:46 +02:00
A_D 0577c08d54 Fixed module docstring 2020-09-22 15:20:46 +02:00
A_D 5ae269d7f6 Added type annotations to examples 2020-09-22 15:20:46 +02:00
A_D 161ca24bb6 updated plugin docs 2020-09-22 15:20:45 +02:00
A_D 470cbaa146 Added example plugin 2020-09-22 15:20:45 +02:00
A_D 4ecb378b83 cleaned up plugins.md 2020-09-22 15:20:44 +02:00
Athanasius a1ae87ed39 Merge pull request #705 from A-UNDERSCORE-D/cleanup/inara-2
Continued inara cleanup
2020-09-22 14:15:32 +01:00
Athanasius e2692ca41d Merge pull request #672 from A-UNDERSCORE-D/cleanup/edsm
Cleanup EDSM plugin
2020-09-22 14:10:24 +01:00
A_D c02b292f50 Removed uneeded list comps 2020-09-22 14:51:45 +02:00
A_D f8523e0a9f removed parens around tuple unpack 2020-09-22 14:49:24 +02:00
A_D e930911415 remove double assign 2020-09-22 14:49:23 +02:00
A_D 9710a5e9bb repalced assert with log and continue 2020-09-22 14:49:23 +02:00
A_D 375573c0a8 fixed docstrings 2020-09-22 14:49:22 +02:00
A_D 615a36452d Added docstrings 2020-09-22 14:49:22 +02:00
A_D 4a7cddc48b removed assert False 2020-09-22 14:48:54 +02:00
A_D 26be93f92e replaced magic number row with var 2020-09-22 14:48:53 +02:00
A_D fb080f8080 Removed unused imports 2020-09-22 14:48:53 +02:00
A_D 893cab3c23 cleaned up logic where possible 2020-09-22 14:48:52 +02:00
A_D f2add920c7 replaced constant contains checks with tuples 2020-09-22 14:48:52 +02:00
A_D 62f3203c3f Added type checker hint for unbound names
Due to the fact that cmdr and entry are only assigned if item exists, a
situation can arise where any access to the names will raise an
UnboundLocalException, this tells the type checker to ignore that
possibility by using a TYPE_CHECKING guarded assignment to those names.

This does not fix the issue at runtime, it just tells the type checker
that its fine. As this remains a bug, I have left TODOs in to note its
existence.
2020-09-22 14:48:51 +02:00
A_D 7ab697a807 Used default option for .get on dicts 2020-09-22 14:48:00 +02:00
A_D 25adf29779 Fixed possible error if credentials is None 2020-09-22 14:48:00 +02:00
A_D 2c2ade05e0 fixed some naming 2020-09-22 14:46:23 +02:00
A_D 20357b3deb replaced modulo formatting with fstrings 2020-09-22 14:46:22 +02:00
A_D 81c977d0da Added type annotations to functions 2020-09-22 14:46:22 +02:00
A_D 14617e72da cleaned up overlong lines 2020-09-22 14:43:24 +02:00
A_D 199e76701d Added line breaks around scope changes 2020-09-22 14:43:24 +02:00
A_D 743984eb11 Added fake definition for _
_ is added by magic in the plugin loading system, which means there are
no imports to indicate its existence to static analysis tools.
2020-09-22 14:41:34 +02:00
A_D d2a1f09fac sorted imports 2020-09-22 14:41:34 +02:00