Athanasius
c1d8a61c60
Whitespace and keyring in requirements sync to develop
2020-08-27 12:56:34 +01:00
Athanasius
550207ab0c
L10n/es.strings: Accidental ">>>>>>> develop" left in
2020-08-27 12:55:16 +01:00
Athanasius
364aaf2aef
Merge branch 'develop' into main
2020-08-27 12:53:03 +01:00
Athanasius
cd21bb554c
edmarketconnector.xml: Fix for accidental "bad merge" text
2020-08-27 12:44:15 +01:00
Athanasius
a9a972fc90
Merge branch 'main' of https://github.com/EDCD/EDMarketConnector into main
2020-08-27 12:18:13 +01:00
Athanasius
f10d7ecd63
Remove greet-everyone workflow, we've gotten things working now
2020-08-27 12:11:50 +01:00
Athanasius
1cda0f9315
Rename to push-checks.yml, don't do PRs
...
Also commented better at the top
2020-08-27 12:11:50 +01:00
Athanasius
a9680ea8c0
Don't force --show-source in .flake8 !
...
This was the cause of our flake8-your-pr issue! It meant that as well
as `--format json` giving JSON output it also got polluted with the raw
string of the source line as well.
2020-08-27 12:11:50 +01:00
Athanasius
9382ca334b
Add flake8-json to requirements-dev.txt
2020-08-27 12:11:50 +01:00
Athanasius
ec1c54b93e
Specify GITHUB_TOKEN for flake8-your-pr via env
2020-08-27 12:11:50 +01:00
Athanasius
ae34a20d11
Attempt to run "tayfun/flake8-your-pr@master" in PRs.
2020-08-27 12:11:50 +01:00
Athanasius
852d0ac7a9
Rename to 'what it runs on' prefix
2020-08-27 12:11:50 +01:00
Athanasius
1cb1bd5725
The configuration must be inside a 'with:'
2020-08-27 12:11:50 +01:00
Athanasius
eddd14724e
Use fetch-depth 0 for 'all' on checkout@v2
2020-08-27 12:11:50 +01:00
Athanasius
85d09edb2a
Try A_D's "diff only" flake8 checking
2020-08-27 12:11:49 +01:00
Athanasius
b175d5711b
Uncomment flake8 part of build in workflow
2020-08-27 12:11:49 +01:00
Athanasius
8ee20039f8
Comments out py2exe in requirements-dev.txt as it trips up GitHub Actions
...
docs/Releasing.md has fuller instructions on getting that specific
pyexe version installed anyway.
2020-08-27 12:11:49 +01:00
Athanasius
a55537e272
Remove pytest and comment out flake8 for now.
...
Narrowing down what's working and what isn't in this.
2020-08-27 12:11:49 +01:00
Athanasius
79b86e5d27
Add greet-example to github workflows
2020-08-27 12:11:49 +01:00
Athanasius
2546efff91
Update python-app.yml
...
Change to ubuntu-18.04
2020-08-27 12:11:49 +01:00
Athanasius
742d133519
Update python-app.yml
...
Change name to be more obvious when viewing in Actions.
2020-08-27 12:11:49 +01:00
Athanasius
a344c53b67
Create python-app.yml
...
Add a GitHub Action to check requirements-dev.txt, flake8, and pytest.
2020-08-27 12:11:49 +01:00
A_D
5b736cab36
Create Enhancement issue template
...
closes #599
2020-08-27 12:10:10 +01:00
A_D
dbcb4bb4fc
clarified docs
2020-08-27 12:10:10 +01:00
A_D
1733aeae5a
Replaced write out checks with guard clauses
...
Guard clauses reduce indentation and help when reading code as they
remove a variable and indentation level that the reader would otherwise
need to keep track of
2020-08-27 12:10:09 +01:00
A_D
8268bfe5da
Removed repeated int(key)
...
With the previous formatting changes there is no reason to leave key as
possibly a string anywhere, as it was already being converted to an int
everywhere anyway
2020-08-27 12:10:09 +01:00
A_D
6a917acde0
Move file backup code to a method
...
It was repeated in various places and increased noise
2020-08-27 12:10:09 +01:00
A_D
3a2e159b1e
Refactor __main__ logic
...
Most of this is just de-pyramiding the code, removing else clauses that
are unneeded (or making the if such that the else is not needed).
Rationale is simple, every level of indentation adds more that the
reader needs to keep track of.
2020-08-27 12:10:09 +01:00
A_D
fe3a6c11f4
replace list literals with tuples
...
Tuples ensure that this isnt changed at runtime
2020-08-27 12:10:09 +01:00
A_D
ed9c1c6774
Replace AssertionErrors with ValueError
...
AssertionError comes from `assert`s, using it for this doesn't make sense as we're complaining about values
2020-08-27 12:10:09 +01:00
A_D
fd3a4852f2
replace modulo formatting with .format
2020-08-27 12:10:09 +01:00
A_D
02d205fbee
removed oneline statements
2020-08-27 12:10:09 +01:00
A_D
a7cf83d1e5
shortened line
2020-08-27 12:10:09 +01:00
A_D
8c0ab2dc75
added missing whitespace where needed
2020-08-27 12:10:09 +01:00
A_D
474c8d144f
removed unused import
2020-08-27 12:10:09 +01:00
A_D
a546ecb735
Add newlines to separate scopes
...
Newlines between scope changes help you to not get lost when reading
source
2020-08-27 12:10:09 +01:00
A_D
7e422c73c4
Fixed code blocks
2020-08-27 12:10:09 +01:00
Athanasius
af3e8f29c7
Updated docs
...
Added linting, testing, and new requirements-dev.txt instructions
2020-08-27 12:10:06 +01:00
Athanasius
6ab6b23d7a
Create requirements-dev.txt
2020-08-27 12:08:53 +01:00
Athanasius
80b7f03f25
Removed dev deps from requirements.txt
2020-08-27 12:08:32 +01:00
A_D
ff7d297167
Add flake8 and autopep8 to requirements.txt
2020-08-27 12:07:44 +01:00
Athanasius
253c6988ca
appcast 4.0.6
2020-08-27 11:32:54 +01:00
Athanasius
a4e1a42783
Version 4.0.6
2020-08-27 11:32:50 +01:00
A_D
d31b0fdbf6
Fixed system link updating on FSDTarget
...
FSDTarget contains the target system under `SystemAddress`, meaning that
any time you selected a star other than the current one, plugins'
`this.system_address` was updated to that target, rather than the
current system. Said updating causes the links provided from system_url
to reflect that update (for providers that support ID64s).
This changes the journal_entry behaviour to only update
`this.system_address` when the event is any of Location, Docked,
or FSDJump, all of which contain only the current system.
2020-08-27 11:32:39 +01:00
Athanasius
a00d5df92b
Update version in BOTH places on that URL line
2020-08-27 11:32:08 +01:00
Athanasius
935c852605
appcast: Update size for 4.0.5
2020-08-27 11:31:52 +01:00
Athanasius
af12816efb
Release 4.0.5: version, changelog, appcast
2020-08-27 11:31:45 +01:00
Athanasius
cea26ad0cd
Releasing.md: Now using Python 3.7.9
2020-08-27 11:30:25 +01:00
Athanasius
c7cdb6ad66
translations: pt-PT: "Use alternate URL method" now translated
2020-08-27 11:30:18 +01:00
Athanasius
c126251246
"Not Python 3.x" popup message sub-substitutions fixed.
...
string.format() doesn't assign to string, so actually need to do that.
2020-08-27 11:30:13 +01:00
