ED/EDMarketConnector
1
0
Fork 0
mirror of https://github.com/EDCD/EDMarketConnector.git synced 2025-04-16 09:10:35 +03:00
Code Issues Projects Releases Wiki Activity
2,093 Commits 16 Branches 276 Tags
Commit Graph

2093 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Athanasius
f85371ac99 EDMCLogging: flake8 cleanup 
* import order.
* Sanitise RotatingFileHandler() call formatting.
 2020-09-07 15:09:11 +01:00
Athanasius
30c9dbefc1 EDMC.py: General flake8 cleanup. 
* Fix f-strings that are just plain strings.
* Sort imports.
* noqa E501 lines I want that long.
* And misc other minor cleanups.
 2020-09-07 15:06:15 +01:00
Athanasius
dde1eb911e EDMCLogging: Misc cleanups 2020-09-07 14:50:12 +01:00
Athanasius
d940357854 EDMarketConnector.py: Blank line at the end. 2020-09-07 14:44:09 +01:00
Athanasius
117c65c4db Logging: Use cleaner pathlib.mkdir() 2020-09-07 14:42:51 +01:00
Athanasius
10c3fec4f8 Logging: Set configured loglevel on creation 2020-09-07 14:40:55 +01:00
Athanasius
c3fbd1164e Logging: Implement additional logging to rotated set of files. 
* All logging duplicated into %TEMP%/{appname}/{logger_name}.log
* These are handled by the RotatingFileHandler, currently set to 1MiB
  per file and 10 backup files.
* Do *NOT* setLevel() on the handlers, as we want to control the level
  up at the logger instead.  This would have caused the CL and GUI
  selection of loglevel to NOT have any effect (hidden by default having
  been DEBUG).
* EDMarketConnector.py now INFO logs its startup and exit.
 2020-09-07 14:17:49 +01:00
Athanasius
faeb579be6 EDMC: Corrections to logging 
* Use appcmdname as the logger name so it looks different from the GUI
  version.  This also causes a different log filename in the rotated log
  set.
* Log at DEBUG for Startup and Exiting.  Which means replacing all of
  the `sys.exit(EXIT_SUCCESS)` with `return` so we can log the Exit
  after `main()` returns and then `sys.exit(EXIT_SUCCESS)` there.
 2020-09-07 14:10:27 +01:00
Athanasius
5c9c9e2056 Logging: Default loglevel now INFO 
We have EDMC CL arg and GUI selection of loglevel now, stored in
settings, so default can be INFO.
 2020-09-07 13:14:20 +01:00
Athanasius
ceca268bdc
Merge pull request #684 from EDCD/feature/logging-select-loglevel 
Feature/logging select loglevel
 2020-09-06 19:29:10 +01:00
Athanasius
815b4695a6 Use logger.exception() to take care of showing the exception. 2020-09-06 19:19:23 +01:00
Athanasius
50c7220455 EDMC: Adding logging, including CL arg to set level 2020-09-06 19:07:37 +01:00
Athanasius
bebe162071 logging: Now setting loglevel from Settings, and loading at start 2020-09-06 18:29:26 +01:00
Athanasius
fa7b6b4daf logging: 'loglevel' preference now saved. 2020-09-06 18:22:10 +01:00
Athanasius
0deeeb5799 logging: Added Settings>Configuration 'Loglevel' option. 
Not yet functional, but dropdown is there and properly populated.
 2020-09-06 18:19:55 +01:00
Athanasius
0142337afe Merge branch 'main' of https://github.com/EDCD/EDMarketConnector into main 2020-09-06 10:25:11 +01:00
Athanasius
3438867ad3 Docs: Reference Bug Report Template if applicable, not general issue URL. 2020-09-06 10:24:30 +01:00
Athanasius
7dc1f97a32 Update issue templates 
Re-arranged "Bug report" template, and included instructions on attaching the log file.
 2020-09-04 21:51:21 +01:00
Athanasius
c3d9ce8c3b Merge branch 'develop' into main 2020-08-27 12:56:59 +01:00
Athanasius
c1d8a61c60 Whitespace and keyring in requirements sync to develop 2020-08-27 12:56:34 +01:00
Athanasius
550207ab0c L10n/es.strings: Accidental ">>>>>>> develop" left in 2020-08-27 12:55:16 +01:00
Athanasius
28c12ff67e Translations: Import latest files 
This syncs up the "Last updated at" time format comments.
 2020-08-27 12:54:16 +01:00
Athanasius
364aaf2aef Merge branch 'develop' into main 2020-08-27 12:53:03 +01:00
Athanasius
cd21bb554c edmarketconnector.xml: Fix for accidental "bad merge" text 2020-08-27 12:44:15 +01:00
Athanasius
a9a972fc90 Merge branch 'main' of https://github.com/EDCD/EDMarketConnector into main 2020-08-27 12:18:13 +01:00
Athanasius
f10d7ecd63 Remove greet-everyone workflow, we've gotten things working now 2020-08-27 12:11:50 +01:00
Athanasius
1cda0f9315 Rename to push-checks.yml, don't do PRs 
Also commented better at the top
 2020-08-27 12:11:50 +01:00
Athanasius
a9680ea8c0 Don't force --show-source in .flake8 ! 
This was the cause of our flake8-your-pr issue!  It meant that as well
as `--format json` giving JSON output it also got polluted with the raw
string of the source line as well.
 2020-08-27 12:11:50 +01:00
Athanasius
9382ca334b Add flake8-json to requirements-dev.txt 2020-08-27 12:11:50 +01:00
Athanasius
ec1c54b93e Specify GITHUB_TOKEN for flake8-your-pr via env 2020-08-27 12:11:50 +01:00
Athanasius
ae34a20d11 Attempt to run "tayfun/flake8-your-pr@master" in PRs. 2020-08-27 12:11:50 +01:00
Athanasius
852d0ac7a9 Rename to 'what it runs on' prefix 2020-08-27 12:11:50 +01:00
Athanasius
1cb1bd5725 The configuration must be inside a 'with:' 2020-08-27 12:11:50 +01:00
Athanasius
eddd14724e Use fetch-depth 0 for 'all' on checkout@v2 2020-08-27 12:11:50 +01:00
Athanasius
85d09edb2a Try A_D's "diff only" flake8 checking 2020-08-27 12:11:49 +01:00
Athanasius
b175d5711b Uncomment flake8 part of build in workflow 2020-08-27 12:11:49 +01:00
Athanasius
8ee20039f8 Comments out py2exe in requirements-dev.txt as it trips up GitHub Actions 
docs/Releasing.md has fuller instructions on getting that specific
pyexe version installed anyway.
 2020-08-27 12:11:49 +01:00
Athanasius
a55537e272 Remove pytest and comment out flake8 for now. 
Narrowing down what's working and what isn't in this.
 2020-08-27 12:11:49 +01:00
Athanasius
79b86e5d27 Add greet-example to github workflows 2020-08-27 12:11:49 +01:00
Athanasius
2546efff91 Update python-app.yml 
Change to ubuntu-18.04
 2020-08-27 12:11:49 +01:00
Athanasius
742d133519 Update python-app.yml 
Change name to be more obvious when viewing in Actions.
 2020-08-27 12:11:49 +01:00
Athanasius
a344c53b67 Create python-app.yml 
Add a GitHub Action to check requirements-dev.txt, flake8, and pytest.
 2020-08-27 12:11:49 +01:00
A_D
5b736cab36 Create Enhancement issue template 
closes #599
 2020-08-27 12:10:10 +01:00
A_D
dbcb4bb4fc clarified docs 2020-08-27 12:10:10 +01:00
A_D
1733aeae5a Replaced write out checks with guard clauses 
Guard clauses reduce indentation and help when reading code as they
remove a variable and indentation level that the reader would otherwise
need to keep track of
 2020-08-27 12:10:09 +01:00
A_D
8268bfe5da Removed repeated int(key) 
With the previous formatting changes there is no reason to leave key as
possibly a string anywhere, as it was already being converted to an int
everywhere anyway
 2020-08-27 12:10:09 +01:00
A_D
6a917acde0 Move file backup code to a method 
It was repeated in various places and increased noise
 2020-08-27 12:10:09 +01:00
A_D
3a2e159b1e Refactor __main__ logic 
Most of this is just de-pyramiding the code, removing else clauses that
are unneeded (or making the if such that the else is not needed).
Rationale is simple, every level of indentation adds more that the
reader needs to keep track of.
 2020-08-27 12:10:09 +01:00
A_D
fe3a6c11f4 replace list literals with tuples 
Tuples ensure that this isnt changed at runtime
 2020-08-27 12:10:09 +01:00
A_D
ed9c1c6774 Replace AssertionErrors with ValueError 
AssertionError comes from `assert`s, using it for this doesn't make sense as we're complaining about values
 2020-08-27 12:10:09 +01:00