Whenever A_D does a PR the checks, for some unclear reason, also contain
'other' files causing unexpected flake8 output.
i.e. PR that changes only plugins/inara.py somehow "git diff .. | flake8"
such that flake8 complains about things in collate.py, coriolis.py,
loadout.py
Sure the `for k, v in ...` means not sending any that are empty/none,
but it will still send the event, just with *no* reputations.
When you're on a fresh character you have no reputations yet, so avoid
causing an Inara API error, including status line text.
Close#581
This at least ensures we're correct after logging back in at a station.
If you relog whilst out at a Settlement then counts will definitely be
wrong now. But there are no events for using consumables, or picking
anything up anyway, so it's almost always going to be off there.
This has an array 'Offered' listing what was traded away.
'Category' & 'Received' is what you got in return, 'Count' many.
Again, we assume this only interacts with ShipLocker, not BackPack.
These are being sold to a Bar Tender.
There's a MicroResources array, one per item name. We assume this is
always selling from ShipLocker, not BackPack.
This is currently only when buying Consumables from a Pioneer Supplies
vendor.
One event per Item type, it's not an array.
We're assuming these go into ShipLocker, not BackPack.
It's unclear from my Journals if this is adding to the current or is the
total state at the time. I think it's the latter, despite not finding
where a '737844537' had come from (looks like from a mission, but that
would be reward and should have gone straight to ShipLocker?).
AppWindow.getandsend() is set on a timer for all of StartUp, Location
and Docked. This means it can trigger up to three times for a login
when docked.
Subsequent calls would hit the cooldown timer and blank the status text
blindly, hiding the 'Last Updated at' text.
To be honest I'm not sure it even needs blanking *then*.
This will trigger the "Where are you?!" message, which now can happen.
I need to double-check this against live behaviour, and might move this
to a different check, as I think on live it's valid to query in-space.
* A lot of this is commented out. It might be useful in the future, but
is just too noisy for now.
* Changed the protocol webserver to info, as it is.
* Left the EDSM 'not 1XX, 2XX or 5XX' in as it's a warning, so 'pass's
on the conditional bodies that would be empty now trace's are
commented.
Also refactors data.py to edmc_data.py as I'm having weird issues with
PyCharm debugger not starting, and this seems to be to do with module
name clashes.
The aim here is to avoid static data in modules that contain code. Why?
So that we can avoid some potential import loops when the 'inner' module
only wants static data but is already imported by the 'outer' module for
code purposes.
A_D
Athanasius
dependabot[bot]